1214822 - Enable button magic on the /choose campaign download page

Status: VERIFIED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

This bug is opened to ensure that the /choose page has the same logic in place as our other download buttons.

Use cases:

- Up to date Firefox users
- Not up to date Firefox
- Non Firefox
- iOS users
*  note: if before the global launch of iOS, users should be redirected to /firefox/ios/
- Android users

Comment 1

[Schalk Neethling [:espressive]]

(In reply to Cory Price [:ckprice] from comment #0)
> This bug is opened to ensure that the /choose page has the same logic in
> place as our other download buttons.
> 
> Use cases:
> 
> - Up to date Firefox users
> - Not up to date Firefox
> - Non Firefox
> - iOS users
> *  note: if before the global launch of iOS, users should be redirected to
> /firefox/ios/
> - Android users

Hey Cory,

I was wondering is/should all of the above not be built into the download button or, is there some logic that we need to carry over to this page from /new or similar? Thanks!

Comment 2

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

(In reply to Schalk Neethling [:espressive] from comment #1)
> Hey Cory,
> 
> I was wondering is/should all of the above not be built into the download
> button or, is there some logic that we need to carry over to this page from
> /new or similar? Thanks!

Let me add rbillings to this discussion. Rebecca, could you please QA the download button on /choose for the different use cases/platforms above? It should match the same action as /new.

Thanks!

Comment 3

[Rebecca Billings [:rbillings]]

Verified using dev-allizom.org/en-US/firefox/choose

Tested on Nightly, Chrome, Safari, Win10 Firefox & Edge, up to date and not up to date Firefox, Android goes to Google play correctly

>> iPhone has "signup to learn more" info but does not redirect to /firefox/iOS

Comment 4

[Schalk Neethling [:espressive]]

So I guess we are all good here? The iOS part still needs to be built into the button, and is part of the fall campaign work if I am not mistaken.

Comment 5

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

>iPhone has "signup to learn more" info but does not redirect to /firefox/iOS

If a user is in a market which has iOS enabled (Canada, New Zealand, etc), the user should be able to access the download button. Can you check this case?

Comment 6

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

OR, until the global launch (bug 1213500), we could just automatically redirect all iOS users to /firefox/ios/ which has the geo logic built in.

/firefox/new/ is currently doing this. :espressive - is this possible?

Comment 7

[Schalk Neethling [:espressive]]

I will look into this and update the bug.

Comment 8

[Schalk Neethling [:espressive]]

(In reply to Cory Price [:ckprice] from comment #6)
> OR, until the global launch (bug 1213500), we could just automatically
> redirect all iOS users to /firefox/ios/ which has the geo logic built in.
> 
> /firefox/new/ is currently doing this. :espressive - is this possible?

See Alex's comment here. Probably a good idea to also waffle the /choose redirect
https://github.com/mozilla/bedrock/pull/3463#issuecomment-150191223

Comment 9

[Cory Price [:ckprice] (bugmail disabled, NI me!)]

Thanks Schalk! Alex's assumption in the PR is correct.

For iOS users:
pre v1.1 launch (Nov 12) = redirect to firefox/ios
post 1.1 launch = no redirect, user should get a link to the App Store directly on /choose/

Note: this is separate from bug 1217211 (it's a mess, I know =/

Comment 10

[Rebecca Billings [:rbillings]]

I'm glad the redirect will be implemented as testing with a faked geolocation is not ideal.

Comment 11

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/11e8849cd2149b2fd9ec3b64a0020783734ad7ed
Fix Bug 1214822, redirect ios users to ios product page from choose

https://github.com/mozilla/bedrock/commit/a74b85b9fd731142c04d572414954d0cde2e9191
Merge pull request #3463 from schalkneethling/bug1214822-redirect-ios-users-to-ios-page

Fix Bug 1214822, redirect ios users to ios product page from choose

Comment 12

[Rebecca Billings [:rbillings]]

Verified on prod