Closed Bug 1216163 Opened 9 years ago Closed 9 years ago

Add 'disabling' state

Categories

(Firefox OS Graveyard :: Sync, defect, P2)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mbdejong
: review+
yifan
: review+
Details | Review 
We may need to do some clean up when login out of FxA so we need to transition the sync state machine to a 'disabling' state where the clean up task is being performed. In case that it fails for any reason, we should go back to the 'enabled' state.
Priority: -- → P2
Target Milestone: --- → FxOS-S10 (30Oct)
Assignee: nobody → ferjmoreno
Blocks: fxos-sync
Won't fix for now. Current cleaners (Browser and Sync app) can shield themselves by checking the latest transaction type of the cleared shared datastores.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
Actually, there are still cases where we need a disabling state.
Status: RESOLVED → REOPENED
Resolution: WONTFIX → ---
Priority: P2 → P3
Blocks: 1217381
Priority: P3 → P2
Comment on attachment 8679450 [details] [review]
[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Michiel, for the phone part. YiFan for the tv one. Thanks!
Attachment #8679450 - Flags: review?(yliao)
Attachment #8679450 - Flags: review?(mbdejong)
Comment on attachment 8679450 [details] [review]
[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Thanks!
Attachment #8679450 - Flags: review?(yliao) → review+
Comment on attachment 8679450 [details] [review]
[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Comments on github.

Transitions are:

    enable
    success
    sync
    disable
    error

Events (states) are:

    disabled
    enabling
    enabled
    syncing
    disabling
    errored
Attachment #8679450 - Flags: review?(mbdejong) → review+
Sorry for the delay! I had seen the r? but then forgot about this one yesterday.
https://github.com/mozilla-b2g/gaia/commit/17d3861ec6ef14a85695a084006d0f77519d3c91
Status: REOPENED → RESOLVED
Closed: 9 years ago → 9 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: