1216163 - Add 'disabling' state

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P2)

Description

[Fernando Jiménez Moreno [:ferjm]]

We may need to do some clean up when login out of FxA so we need to transition the sync state machine to a 'disabling' state where the clean up task is being performed. In case that it fails for any reason, we should go back to the 'enabled' state.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

Won't fix for now. Current cleaners (Browser and Sync app) can shield themselves by checking the latest transaction type of the cleared shared datastores.

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

Actually, there are still cases where we need a disabling state.

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8679450 [details] [review]
[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Michiel, for the phone part. YiFan for the tv one. Thanks!

Comment 5

[yifan [:yifan][:yliao]]

Comment on attachment 8679450 [details] [review]
[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Thanks!

Comment 6

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8679450 [details] [review]
[gaia] ferjm:bug1216163.disabling.sync > mozilla-b2g:master

Comments on github.

Transitions are:

    enable
    success
    sync
    disable
    error

Events (states) are:

    disabled
    enabling
    enabled
    syncing
    disabling
    errored

Comment 7

[Michiel de Jong [:michielbdejong]]

Sorry for the delay! I had seen the r? but then forgot about this one yesterday.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/17d3861ec6ef14a85695a084006d0f77519d3c91