Closed Bug 1217381 Opened 8 years ago Closed 8 years ago

Go back to default collection settings on logout

Categories

(Firefox OS Graveyard :: Sync, defect, P2)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(b2g-v2.5 fixed)

Status:
RESOLVED FIXED
Milestone:
FxOS-S10 (30Oct)
Tracking Flags:
Tracking Status
b2g-v2.5 --- fixed

People

(Reporter: ferjm, Assigned: ferjm)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file)

[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master
46 bytes, text/x-github-pull-request
mbdejong
: review+
yifan
: review+
mpotharaju
: approval-gaia-v2.5+
Details | Review 
      No description provided.
Assignee: nobody → ferjmoreno
Blocks: fxos-sync
Priority: -- → P2
Target Milestone: --- → FxOS-S10 (30Oct)
Depends on: 1216163
Priority: P2 → P3
Priority: P3 → P2
Attachment #8679465 - Flags: review?(yliao)
Attachment #8679465 - Flags: review?(mbdejong)
I filed bug 1220600 to also save/restore user preferences.
Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Thanks! Should we enable save/restore settings per user?
Attachment #8679465 - Flags: review?(yliao) → review+
(In reply to yifan [:yifan][:yliao] from comment #3)
> Comment on attachment 8679465 [details] [review]
> [gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master
> 
> Thanks! Should we enable save/restore settings per user?

That's bug 1220600
Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Cool! Comments on github.
Attachment #8679465 - Flags: review?(mbdejong) → review+
It's not ideal that the user needs to change settings each time they log in, and as discussed on irc, the proper solution for that would be if we could have real Gonk-level or Gecko-level user profiles on Firefox OS.

For the case of multiple users using the TV, this is patch is indeed an improvement. Getting the device's default settings each time is better than inheriting whatever the last user's settings were. :)
Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Firefox Sync
[User impact] if declined: New users will inherit old users preferences.
[Testing completed]: Unit tests added.
[Risk to taking this patch] (and alternatives if risky): Low risk. This is part of a new feature that is under QA testing right now.
[String changes made]: None
Attachment #8679465 - Flags: approval-gaia-v2.5?
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks
Attachment #8679465 - Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
Hi, this has conflicts uplifting to 2.5. Could you create a PR request for the 2.5 uplift, thanks!
Flags: needinfo?(ferjmoreno)
This one is already in 2.5. I requested approval before the merge of master and 2.5. Sorry for the confusion.
Flags: needinfo?(ferjmoreno)
(In reply to Fernando Jiménez Moreno [:ferjm] from comment #11)
> This one is already in 2.5. I requested approval before the merge of master
> and 2.5. Sorry for the confusion.

np :) setting flag too
status-b2g-v2.5: --- → fixed
You need to log in before you can comment on or make changes to this bug.