1217381 - Go back to default collection settings on logout

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P2)

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

I filed bug 1220600 to also save/restore user preferences.

Comment 3

[yifan [:yifan][:yliao]]

Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Thanks! Should we enable save/restore settings per user?

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

(In reply to yifan [:yifan][:yliao] from comment #3)
> Comment on attachment 8679465 [details] [review]
> [gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master
> 
> Thanks! Should we enable save/restore settings per user?

That's bug 1220600

Comment 5

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Cool! Comments on github.

Comment 6

[Michiel de Jong [:michielbdejong]]

It's not ideal that the user needs to change settings each time they log in, and as discussed on irc, the proper solution for that would be if we could have real Gonk-level or Gecko-level user profiles on Firefox OS.

For the case of multiple users using the TV, this is patch is indeed an improvement. Getting the device's default settings each time is better than inheriting whatever the last user's settings were. :)

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/64248276ddd182888d68a3cb68c22460bfbc91e3

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Firefox Sync
[User impact] if declined: New users will inherit old users preferences.
[Testing completed]: Unit tests added.
[Risk to taking this patch] (and alternatives if risky): Low risk. This is part of a new feature that is under QA testing right now.
[String changes made]: None

Comment 9

[Mahendra Potharaju [:mahe]]

Comment on attachment 8679465 [details] [review]
[gaia] ferjm:bug1217381.default.settings > mozilla-b2g:master

Approved for 2.5 uplift. 

Thanks

Comment 10

[Carsten Book [:Tomcat]]

Hi, this has conflicts uplifting to 2.5. Could you create a PR request for the 2.5 uplift, thanks!

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

This one is already in 2.5. I requested approval before the merge of master and 2.5. Sorry for the confusion.

Comment 12

[Carsten Book [:Tomcat]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #11)
> This one is already in 2.5. I requested approval before the merge of master
> and 2.5. Sorry for the confusion.

np :) setting flag too