Closed
Bug 1216212
Opened 9 years ago
Closed 9 years ago
Remove hack for tapping between 3-dot menu and edge of screen on tablet
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
INVALID
People
(Reporter: mcomella, Assigned: sergej, Mentored)
References
Details
Attachments
(1 file)
bug 1144707 landed this hack that is caused by bug 1216114. Once bug 1216114 lands, we should remove the hack to reduce code complexity.
|
Assignee | |
Comment 1•9 years ago
|
||
Bug 1216212 - Remove hack for tapping between 3-dot menu and edge of screen on tablet
Attachment #8676557 -
Flags: review?(michael.l.comella)
|
Reporter | |
Updated•9 years ago
|
Assignee: nobody → sergej
|
|
Reporter | |
Comment 2•9 years ago
|
||
Comment on attachment 8676557 [details]
MozReview Request: Bug 1216212 - Remove hack for tapping between 3-dot menu and edge of screen on tablet
https://reviewboard.mozilla.org/r/22749/#review20271
This looks good to me!
I notice that tapping the margin selects the browser toolbar but does not trigger the context menu – I'll comment in the other bug.
Attachment #8676557 -
Flags: review?(michael.l.comella) → review+
|
||
Comment 3•9 years ago
|
||
We might need to keep this hack for now - now that we moved the context menu to BrowserToolbar again.
Flags: needinfo?(michael.l.comella)
|
|
Reporter | |
Comment 4•9 years ago
|
||
(In reply to Sebastian Kaspari (:sebastian) from comment #3)
> We might need to keep this hack for now - now that we moved the context menu
> to BrowserToolbar again.
Yep, I agree.
Status: NEW → RESOLVED
Closed: 9 years ago
Flags: needinfo?(michael.l.comella)
Resolution: --- → INVALID
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•