1216971 - Browser toolbar is highlighted when tapping margin at the edge of the screen

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, defect)

Description

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

Bug 1216114 removed the context menu that caused the hack removed by bug 1216212 to be necessary. However, during review for bug 1216212, I notice that when tapping the margin between the 3-dot menu and the edge of the screen on tablet, the browser toolbar is selected (or highlighted).

Sergej, do you have any ideas?

Comment 1

[Sergej Kravcenko]

Do you have both patches applied  1216114 and 1216212?

Comment 2

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

(In reply to Sergej Kravcenko from comment #1)
> Do you have both patches applied  1216114 and 1216212?

I believe so – I applied the patch I reviewed and the other patch was already landed. Can you repro?

Comment 3

[Michael Comella (:mcomella) [NI reported issues only: ex-Mozilla]]

fwiw, I tested on an N9.

Comment 4

[Sergej Kravcenko]

I managed to reproduce this, toolbar layout is still clickable. I've found some comments related to focus order, need to double check this with real keyboard. Don't want to break existing focusing chain, if I disable clicks in toolbar.

Comment 5

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.