Closed Bug 1216559 Opened 9 years ago Closed 9 years ago

Remove smart collections and test

Categories

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::UI Tests
Platform:
ARM
Gonk (Firefox OS)
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jlorenzo, Assigned: martijn.martijn)

References

Details

Attachments

(1 file)

[gaia] mwargers:1216559 > mozilla-b2g:master
46 bytes, text/x-github-pull-request
njpark
: review+
jlorenzo
: review+
Details | Review 
      No description provided.
The other rocketbar tests were fixed in bug 1216084. 
http://mxr.mozilla.org/gaia/source/tests/python/gaia-ui-tests/gaiatest/tests/functional/rocketbar/test_rocketbar_add_collection_save_bookmark.py
is failing and I disabled that one for now in bug 1216084.
I'll make this bug about fixing that test.
Smart collections will be removed completely, see bug 1213172.
So we should just remove everything smart collections related.
Summary: Update the rocketbar tests now that is belongs to the system app → Remove smart collections and test
Attachment #8676463 - Flags: review?(npark)
Attachment #8676463 - Flags: review?(jlorenzo)
Comment on attachment 8676463 [details] [review]
[gaia] mwargers:1216559 > mozilla-b2g:master

I perform some usage search in PyCharm, and I didn't find any test that:
* uses the smart collections page objects (or one of the functions that return them)
* is not deleted in the PR, or will not be fixed by bug 1216560.

Looks good to me.
Attachment #8676463 - Flags: review?(jlorenzo) → review+
See Also: → 1216560
Comment on attachment 8676463 [details] [review]
[gaia] mwargers:1216559 > mozilla-b2g:master

Don't think we have any smart collection related tests other than ones that are deleted here.
Attachment #8676463 - Flags: review?(npark) → review+
Merged: https://github.com/mozilla-b2g/gaia/commit/692e843828bf965c3ecafcadfd8d0e5cc788d582
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: