1216084 - Fix the Gaia UI tests that are failing because of the new Homescreen

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Description

[Martijn Wargers (dead)]

It looks like the new homescreen landed, this means a lot of the Gaia UI tests will fail.
We need to fix that.

Comment 1

[Martijn Wargers (dead)]

The setting to the new homescreen is: "homescreen.manifestURL": "app://homescreen.gaiamobile.org/manifest.webapp", btw.

Comment 2

[Martijn Wargers (dead)]

Attachment: homescreenresults.txt

These are the failures I see in the homescreen tests.

Comment 3

[Chris Lord [:cwiiis]]

I wonder how many of these tests actually make sense given the marionettejs coverage - is there any advantage (other than possibly more thorough testing) by testing the same thing twice in both python tests and marionettejs tests?

Comment 4

[Martijn Wargers (dead)]

Marionettejs tests aren't running on device.

Comment 5

[Chris Lord [:cwiiis]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #4)
> Marionettejs tests aren't running on device.

ah, fair.

So looking at the tests, you'll want to remove
test_homescreen_change_wallpaper.py (there's no settings menu anymore)
test_homescreen_divider.py (there are no dividers)
test_homescreen_edit_mode.py (there's no edit mode)

and the rest should be easily fixable (the DOM is different to verticalhome, but similar - and there are some changes that make tests easier to write, like the fact that DOM order is always in sync with app order now). The marionettejs tests/library should make it obvious how to fix the tests.

Comment 6

[Martijn Wargers (dead)]

Attachment: rocketbarresults.txt

Failures with rocketbar

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1216084 > mozilla-b2g:master

Comment 8

[Chris Lord [:cwiiis]]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #6)
> Created attachment 8675615 [details]
> rocketbarresults.txt
> 
> Failures with rocketbar

Rocketbar failures should be even easier to fix - new homescreen now works like a normal application with respect to the rocketbar - it no longer has its own in-line search bar, the system one remains visible.

Comment 9

[Johan Lorenzo [:jlorenzo]]

Let's break down the fixes in many small ones. See the dependencies for details.

Comment 10

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8675620 [details] [review]
[gaia] mwargers:1216084 > mozilla-b2g:master

There are some things that we can improve in apps/system/regions/search_panel.py
, but due to the fact that no test is passing, I won't block on them.

Comment 11

[No-Jun Park [:njpark]]

Comment on attachment 8675620 [details] [review]
[gaia] mwargers:1216084 > mozilla-b2g:master

locale issues are a carryover from previous version, and i don't see other issues.

Comment 12

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/2e80edf807887ce8afa8b88bfdf5a2b2cafe5ba6

Comment 13

[Chris Lord [:cwiiis]]

A heads-up, bug 1218805 changes how home screen icon editing works a bit, in case there are any tests around this functionality. The changes required in marionette tests were minimal.

Comment 14

[Martijn Wargers (dead)]

Hah, we already removed the edit functionality testing. I guess we need to add some of these tests back.

Comment 15

[Martijn Wargers (dead)]

I guess homescreen edit is something that can be handled by the Gij tests.

Comment 16

[Martijn Wargers (dead)]

Marking WONTFIX, sorry for the bug spam. If somebody still wants to work on this, please file a new bug for it.