1216564 - Update launch{_packaged}_app.py and spark_apps_presents.py in order to support the new homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Comment 1

[Martijn Wargers (dead)]

I tried initially something here: https://bug1216562.bmoattachments.org/attachment.cgi?id=8676345

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] mwargers:1216564 > mozilla-b2g:master

Comment 3

[Martijn Wargers (dead)]

Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

Ok, this fixes the 4 tests in the pull request.
I wonder how test_homescreen_status_bar_icons_visibility.py still is, because the homescreen acts totally differently.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

Good call for all the manifest URL! I don't see anything blocking in this patch. Thanks!

Comment 5

[Martijn Wargers (dead)]

Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

Johan, I have added test_spark_apps_present.py to this now, could you take a look at that file and see if you agree with this?
I noticed there are some other apps on the Spark currently, which are not in this test, namely MozSpeech and Foxfooding. Do they need to be added?

Comment 6

[No-Jun Park [:njpark]]

Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

good to see the time.sleep() calls are gone too.  I should make sure that I do not re-introduce what you have removed here.

Comment 7

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

LGTM

Comment 8

[Martijn Wargers (dead)]

Merged: https://github.com/mozilla-b2g/gaia/commit/40339f9e6fe26611d65c6b804df3c11670297345

Comment 9

[Martijn Wargers (dead)]

(In reply to Martijn Wargers [:mwargers] (QA) from comment #5)
> I noticed there are some other apps on the Spark currently, which are not in
> this test, namely MozSpeech and Foxfooding. Do they need to be added?

I filed bug 1217054 for this.