Update launch{_packaged}_app.py and spark_apps_presents.py in order to support the new homescreen

RESOLVED FIXED

Status

Firefox OS
Gaia::UI Tests
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: jlorenzo, Assigned: Martijn Wargers (dead))

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Updated

2 years ago
Assignee: nobody → martijn.martijn
(Assignee)

Comment 1

2 years ago
I tried initially something here: https://bug1216562.bmoattachments.org/attachment.cgi?id=8676345
Created attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master
(Assignee)

Comment 3

2 years ago
Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

Ok, this fixes the 4 tests in the pull request.
I wonder how test_homescreen_status_bar_icons_visibility.py still is, because the homescreen acts totally differently.
Attachment #8676528 - Flags: review?(npark)
Attachment #8676528 - Flags: review?(jlorenzo)
(Reporter)

Comment 4

2 years ago
Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

Good call for all the manifest URL! I don't see anything blocking in this patch. Thanks!
Attachment #8676528 - Flags: review?(jlorenzo) → review+
(Assignee)

Comment 5

2 years ago
Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

Johan, I have added test_spark_apps_present.py to this now, could you take a look at that file and see if you agree with this?
I noticed there are some other apps on the Spark currently, which are not in this test, namely MozSpeech and Foxfooding. Do they need to be added?
Attachment #8676528 - Flags: review+ → review?(jlorenzo)
Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

good to see the time.sleep() calls are gone too.  I should make sure that I do not re-introduce what you have removed here.
Attachment #8676528 - Flags: review?(npark) → review+
(Reporter)

Updated

2 years ago
Depends on: 1216562
(Reporter)

Comment 7

2 years ago
Comment on attachment 8676528 [details] [review]
[gaia] mwargers:1216564 > mozilla-b2g:master

LGTM
Attachment #8676528 - Flags: review?(jlorenzo) → review+
(Assignee)

Comment 8

2 years ago
Merged: https://github.com/mozilla-b2g/gaia/commit/40339f9e6fe26611d65c6b804df3c11670297345
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

2 years ago
(In reply to Martijn Wargers [:mwargers] (QA) from comment #5)
> I noticed there are some other apps on the Spark currently, which are not in
> this test, namely MozSpeech and Foxfooding. Do they need to be added?

I filed bug 1217054 for this.
(Reporter)

Updated

2 years ago
Blocks: 1216562
No longer depends on: 1216562
You need to log in before you can comment on or make changes to this bug.