1216562 - Update move_app and delete{_packaged}_app in order to support the new homescreen

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::UI Tests, defect)

Comment 1

[Martijn Wargers (dead)]

Attachment: all.diff

I was first trying to get this test fixed, but figured out soon that it was more difficult than I thought. Here is a diff of what I did then, perhaps there is some usefulness in here.

Comment 2

[Johan Lorenzo [:jlorenzo]]

Martijn solve some parts of the problem that I'll use (bug 1216564).

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] JohanLorenzo:bug-1216562 > mozilla-b2g:master

Comment 4

[Johan Lorenzo [:jlorenzo]]

I have a first patch. The delete test takes longer to be executed due to a timeout. I'll fix it. There is also delete_app_packaged that could be merged with delete_app, I think.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8677402 [details] [review]
[gaia] JohanLorenzo:bug-1216562 > mozilla-b2g:master

I couldn't find a better way to wait for the app to be not displayed anymore. I tried to use Base.is_element_displayed() but I got Python error:
> UnboundLocalError: local variable 'wrapped' referenced before assignment

After looking it up, there is somewhere in the code where I tried to change the content of an external variable. 

If you guys have any other idea.

Comment 6

[Martijn Wargers (dead)]

Comment on attachment 8677402 [details] [review]
[gaia] JohanLorenzo:bug-1216562 > mozilla-b2g:master

nice how test_homescreen_delete_app.py and test_homescreen_delete_app_packaged.py can be combined.
I wonder how app_elements works, I thought you would need to do switch_to_shadow_root() to some element at some point.

Comment 7

[No-Jun Park [:njpark]]

Comment on attachment 8677402 [details] [review]
[gaia] JohanLorenzo:bug-1216562 > mozilla-b2g:master

looks good to me.

Comment 8

[Johan Lorenzo [:jlorenzo]]

I rebased on top of No-Jun's patch. I checked for any other dead reference in the Homescreen page class. Only bookmark is remaining, it'll be handled in bug 1217404.

I ran the manifest file in the homescreen. Every test was passing. I checked the content of manifest, only test_homescreen_status_bar_icons_visibility.py is still not run. Not sure if we should remove or update it. Let's see that in bug 1217870.

Landed in master at: https://github.com/mozilla-b2g/gaia/commit/3e7e5f9af1646dfdf9e45f00e5860e533c024b47