1216699 - Add Learn More link to Insecure Password Warning in Control Center

Status: VERIFIED FIXED

(Firefox :: Security, defect, P1)

Description

[Tanvi Vyas[:tanvi]]

We need to add a Learn More link to the subpanel on HTTP pages with password fields.  The lock witht he corssthrough will be a new icon for most users and developers.  When they see this on an HTTP page an drill down, they end up at the "More Information" button.  That button doesn't actually give them any information about this.

I believe we can add this pretty easily.

Comment 1

[Tanvi Vyas[:tanvi]]

Attachment: Bug1216699-10-29-15-wip.patch

Here is a work in progress patch, but it is broken.  Haven't had a chance to debug, but wanted to put this here in case someone picks up this bug.

Comment 2

[:Paolo Amadini]

Thanks a lot for the patch, I've updated it and will post it for review now.

Note that the link redirects to a page that says "This article doesn't have approved content yet".

Comment 3

[:Paolo Amadini]

Attachment: MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

Comment 4

[Tanvi Vyas[:tanvi]]

(In reply to :Paolo Amadini from comment #2)
> Thanks a lot for the patch, I've updated it and will post it for review now.
> 
> Note that the link redirects to a page that says "This article doesn't have
> approved content yet".

Yes; Joni and I have to add content.  We have a bug open for that too - https://bugzilla.mozilla.org/show_bug.cgi?id=1217165

Comment 5

[Brian Grinstead [:bgrins]]

Comment on attachment 8681290 [details]
MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

https://reviewboard.mozilla.org/r/23793/#review21285

Looks good to me

Comment 6

[:Paolo Amadini]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a510b63f0c2

Comment 7

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/47457f01c243

Comment 8

[Tanvi Vyas[:tanvi]]

Comment on attachment 8681290 [details]
MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: https://bugzilla.mozilla.org/show_bug.cgi?id=1179961
[User impact if declined]: No information about the security issue with insecure passwords is given to developers
[Describe test coverage new/current, TreeHerder]: Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a510b63f0c2 and testcase added to browser/base/content/test/general/browser_insecureLoginForms.js 
[Risks and why]: Just adding a Learn More link in the UI in the Control Center subpanel, low risk
[String/UUID change made/needed]: None

Comment 9

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/47457f01c243

Comment 10

[Paul Silaghi, QA [:pauly]]

Verified fixed FF 45.0a1 (2015-11-02) Win 7 on:
http://people.mozilla.org/~tvyas/password/password_insecure.html
http://people.mozilla.org/~tvyas/password/frame_password.html

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/47457f01c243

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8681290 [details]
MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

Given that this feature was verified by QE, it seems safe to uplift to Aurora44.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c36066cd9585

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/c36066cd9585

Comment 15

[Paul Silaghi, QA [:pauly]]

I don't see the "Learn More" link in Aurora 44.0a2 (2015-11-09), but I guess that's because of the bug 1221206, right?

Comment 16

[:Paolo Amadini]

Yeah, that's correct.

Comment 17

[:Paolo Amadini]

You may try to switch the preference manually and see if the link is there.

Comment 18

[Paul Silaghi, QA [:pauly]]

Thanks. Works fine with security.insecure_password.ui.enabled=TRUE.
Verified fixed 44.0a2 (2015-11-09) Win 7.

Note 2 observations about the "Learn more" link:
1. right click context menu doesn't work
2. middle click doesn't work