Closed Bug 1216699 Opened 4 years ago Closed 4 years ago

Add Learn More link to Insecure Password Warning in Control Center

Categories

(Firefox :: Security, defect, P1)

44 Branch
defect

Tracking

()

VERIFIED FIXED
Firefox 45
Iteration:
44.3 - Nov 2
Tracking Status
firefox44 --- verified
firefox45 --- verified

People

(Reporter: tanvi, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxprivacy])

Attachments

(1 file, 1 obsolete file)

We need to add a Learn More link to the subpanel on HTTP pages with password fields.  The lock witht he corssthrough will be a new icon for most users and developers.  When they see this on an HTTP page an drill down, they end up at the "More Information" button.  That button doesn't actually give them any information about this.

I believe we can add this pretty easily.
Priority: -- → P3
Whiteboard: [fxprivacy] [triage] → [fxprivacy]
Blocks: 1217142
Blocks: 1217165
Priority: P3 → P2
Attached patch Bug1216699-10-29-15-wip.patch (obsolete) — Splinter Review
Here is a work in progress patch, but it is broken.  Haven't had a chance to debug, but wanted to put this here in case someone picks up this bug.
Thanks a lot for the patch, I've updated it and will post it for review now.

Note that the link redirects to a page that says "This article doesn't have approved content yet".
Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins
Attachment #8681290 - Flags: review?(bgrinstead)
Attachment #8680865 - Attachment is obsolete: true
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Iteration: --- → 44.3 - Nov 2
Flags: qe-verify?
Priority: P2 → P1
Flags: qe-verify? → qe-verify+
(In reply to :Paolo Amadini from comment #2)
> Thanks a lot for the patch, I've updated it and will post it for review now.
> 
> Note that the link redirects to a page that says "This article doesn't have
> approved content yet".

Yes; Joni and I have to add content.  We have a bug open for that too - https://bugzilla.mozilla.org/show_bug.cgi?id=1217165
Comment on attachment 8681290 [details]
MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

https://reviewboard.mozilla.org/r/23793/#review21285

Looks good to me
Attachment #8681290 - Flags: review?(bgrinstead) → review+
Comment on attachment 8681290 [details]
MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

Approval Request Comment
[Feature/regressing bug #]: https://bugzilla.mozilla.org/show_bug.cgi?id=1179961
[User impact if declined]: No information about the security issue with insecure passwords is given to developers
[Describe test coverage new/current, TreeHerder]: Pushed to try https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a510b63f0c2 and testcase added to browser/base/content/test/general/browser_insecureLoginForms.js 
[Risks and why]: Just adding a Learn More link in the UI in the Control Center subpanel, low risk
[String/UUID change made/needed]: None
Attachment #8681290 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/47457f01c243
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
QA Contact: paul.silaghi
Comment on attachment 8681290 [details]
MozReview Request: Bug 1216699 - Add Learn More link to Insecure Password Warning in Control Center. r=bgrins

Given that this feature was verified by QE, it seems safe to uplift to Aurora44.
Attachment #8681290 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
I don't see the "Learn More" link in Aurora 44.0a2 (2015-11-09), but I guess that's because of the bug 1221206, right?
Yeah, that's correct.
You may try to switch the preference manually and see if the link is there.
Thanks. Works fine with security.insecure_password.ui.enabled=TRUE.
Verified fixed 44.0a2 (2015-11-09) Win 7.

Note 2 observations about the "Learn more" link:
1. right click context menu doesn't work
2. middle click doesn't work
Blocks: 1188121
No longer blocks: 1188121
You need to log in before you can comment on or make changes to this bug.