[browser] handle back-space key event in firefox sync process

RESOLVED FIXED in FxOS-S10 (30Oct)

Status

Firefox OS
Gaia::TV::Browser
P2
normal
RESOLVED FIXED
3 years ago
3 years ago

People

(Reporter: danhuang, Assigned: yifan)

Tracking

unspecified
FxOS-S10 (30Oct)
ARM
Gonk (Firefox OS)
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 attachment)

46 bytes, text/x-github-pull-request
ferjm
: review+
Details | Review | Splinter Review
(Reporter)

Description

3 years ago
This is a follow up bug for Bug 1203898. We need to discuss if we need to enable a user to cancel the sign in flow.
(Reporter)

Comment 1

3 years ago
Hi Tori, we need to discuss if we need to enable a user to cancel the signin flow in tv browser.
Flags: needinfo?(tchen)
(Reporter)

Updated

3 years ago
Flags: needinfo?(tchen)
Summary: [browser] enable a user to cancel the sign in flow → [browser] handle back-space key event in firefox sync process
(Reporter)

Comment 2

3 years ago
This bug is updated to handle back key event in firefox sync process.
(Reporter)

Updated

3 years ago
Blocks: 1194108
Blocks: 824026
Priority: -- → P2
Target Milestone: --- → FxOS-S10 (30Oct)
(In reply to Dan Huang[:danhuang] from comment #1)
> Hi Tori, we need to discuss if we need to enable a user to cancel the signin
> flow in tv browser.

We need to allow canceling the flow. Otherwise the user will be stuck in the FxA login page if she has no account.
(Assignee)

Updated

3 years ago
Assignee: nobody → yliao
(Assignee)

Comment 4

3 years ago
Created attachment 8678777 [details] [review]
pull request
Attachment #8678777 - Flags: review?(ferjmoreno)
Comment on attachment 8678777 [details] [review]
pull request

LGTM. Thank you!
Attachment #8678777 - Flags: review?(ferjmoreno) → review+
(Assignee)

Comment 6

3 years ago
https://github.com/mozilla-b2g/gaia/commit/977db6ca35badf2d7725b3299d3d4b91169bce11
Status: NEW → RESOLVED
Last Resolved: 3 years ago
Resolution: --- → FIXED
(Assignee)

Updated

3 years ago
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.