Closed Bug 1216878 Opened 4 years ago Closed 4 years ago

[browser] export bookmarkList.js as a general list render library in tv

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(Not tracked)

RESOLVED FIXED
FxOS-S10 (30Oct)

People

(Reporter: danhuang, Assigned: danhuang)

References

Details

(Whiteboard: [partner-cherry-pick])

Attachments

(1 file, 1 obsolete file)

Export bookmarkList.js as a general list render library in tv. This list render library can use for bookmark and history.
Blocks: TV_FxAccount
Depends on: 1202376
Depends on: 1194091
Assignee: nobody → dhuang
Attachment #8677410 - Attachment is obsolete: true
Priority: -- → P1
Target Milestone: --- → FxOS-S10 (30Oct)
Comment on attachment 8678447 [details] [review]
[gaia] danhuang1202:1216878_export_bookmarkList_as_library > mozilla-b2g:master

Hi Yi-fan, please help to review. This patch export bookmarkList.js to smartList.js. And the different between these two file is that the smartList.js add a init() to create dom tree structure for smart list. Thanks.
Attachment #8678447 - Flags: review?(yliao)
Comment on attachment 8678447 [details] [review]
[gaia] danhuang1202:1216878_export_bookmarkList_as_library > mozilla-b2g:master

LGTM. Thanks!
Attachment #8678447 - Flags: review?(yliao) → review+
Thanks for the review.
Merge in master:
https://github.com/mozilla-b2g/gaia/commit/b4f3fad58aca51bcc6568d0f922114de02c80285
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Whiteboard: [partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.