Closed Bug 1202376 Opened 4 years ago Closed 4 years ago

[browser] Implement Bookmark folder navigation in TV

Categories

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

ARM
Gonk (Firefox OS)
defect

Tracking

(feature-b2g:2.5+)

RESOLVED FIXED
FxOS-S9 (16Oct)
feature-b2g 2.5+

People

(Reporter: danhuang, Assigned: danhuang)

References

Details

(Whiteboard: [ft:conndevices][partner-blocker][partner-cherry-pick])

Attachments

(4 files)

After firefox account sign in and bookmark data sync. The browser needs ui for display bookmark list and interaction.
Assignee: nobody → dhuang
Status: NEW → ASSIGNED
No longer depends on: 1194090
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

Please help to review. This patch had add smart_list.js to implement bookmark navigation and integrate with awesomescreen.js's event handler. Also fix js lint error in awesomescreen.js. Thanks.
Attachment #8664111 - Flags: review?(rexboy)
No longer blocks: TV_Pocket
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

Please help to review. This patch had add smart_list.js to implement bookmark navigation and integrate with awesomescreen.js's event handler. Also fix js lint error in awesomescreen.js. Thanks.
Attachment #8664111 - Flags: review?(rexboy) → review?(yliao)
This patch has mock bookmark data.
Attachment #8665359 - Flags: review?(yliao)
feature-b2g: --- → 2.5+
Attachment #8665359 - Flags: review?(yliao)
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

Thanks for the effort! Please refer to code comments and make changes according to previous discussion.
Attachment #8664111 - Flags: review?(yliao) → review-
Target Milestone: --- → FxOS-S9 (16Oct)
Component: Gaia::TV → Gaia::TV::Browser
Blocks: TV_FxAccount
No longer depends on: TV_FxAccount
No longer depends on: 1194098
Hi Dan,
Do you have any update for Bookmark folder navigation in TV?
Flags: needinfo?(dhuang)
still working on fix nits and also implement infinite scroll in bookmark scroll
Flags: needinfo?(dhuang)
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

Please help me to review. This patch add infinite scroll and update visual by spec. Thanks.
Attachment #8664111 - Flags: review- → review?(yliao)
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

This patch seems to break the original add bookmark functionality. Also please see the comments on Github.
Attachment #8664111 - Flags: review?(yliao) → review-
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

Hi Yifan, this new patch fix nits in your comment. And this patch is use mock data for demo, so the add bookmark would not work correctly. But if remove the demo part of the mock data, add bookmark can work well. Thanks.
Attachment #8664111 - Flags: review- → review?(yliao)
Comment on attachment 8664111 [details] [review]
[gaia] danhuang1202:1202376_tv_browser_bookmark_navigation > mozilla-b2g:master

Thank you for the great help! I've updated comments on Github, mostly nits. Please update the PR.
Attachment #8664111 - Flags: review?(yliao) → review-
Comment on attachment 8676140 [details] [review]
[gaia] danhuang1202:revert_1202376 > mozilla-b2g:master

Hi, Yi-fan, this patch fix nits you point out in https://github.com/mozilla-b2g/gaia/pull/31964. Please help me to review, thanks.
Attachment #8676140 - Flags: review?(yliao)
Comment on attachment 8676140 [details] [review]
[gaia] danhuang1202:revert_1202376 > mozilla-b2g:master

This is the revert PR.
Attachment #8676140 - Flags: review?(yliao)
Comment on attachment 8676604 [details] [review]
[gaia] danhuang1202:1202376_bookmark_navigation_in_tv_browser > mozilla-b2g:master

Hi, Yi-fan, sorry for the wrong patch attachment. This patch is updated, please help me to review, thanks.
Attachment #8676604 - Flags: review?(yliao)
Comment on attachment 8676604 [details] [review]
[gaia] danhuang1202:1202376_bookmark_navigation_in_tv_browser > mozilla-b2g:master

Thank you for the great help! LGTM.
Attachment #8676604 - Flags: review?(yliao) → review+
Blocks: 1216878
Thanks for the review.
Merge in master:
https://github.com/mozilla-b2g/gaia/commit/98e47a6c98f48b7a326822f2113f33f2c58c85cb
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Depends on: 1218701
No longer depends on: 1194092
Whiteboard: [ft:conndevices][partner-blocker] → [ft:conndevices][partner-blocker][partner-cherry-pick]
You need to log in before you can comment on or make changes to this bug.