1217015 - move xpcAccEvents.cpp to GENERATED_FILES

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Nathan Froyd [:froydnj]]

Once we can generate deps support, this will be easy(ier) and enable us to remove a Makefile.in.

Comment 1

[Chris Manchester (limited bugmail, email directly)]

Attachment: MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

https://reviewboard.mozilla.org/r/23513/#review20959

::: accessible/xpcom/AccEventGen.py:205
(Diff revision 1)
> -def main():
> -    from argparse import ArgumentParser
> +    sdk_path = mozpath.join(buildconfig.substs['LIBXUL_DIST'], 'sdk', 'bin')
> +    sys.path.append(sdk_path)

You can skip this. The whole business with LIBXUL_DIST/sdk/bin comes from --with-libxul-sdk builds, but that has been removed.

Which means you can include xpidl globally and don't need xpidl_attr_type anymore.

This should also simplify gen_file enough that you can just inline it in gen_header_file and gen_cpp_file.

That being said, I'm not sure it's wise to have the script be invoked twice instead of once.

Comment 3

[Chris Manchester (limited bugmail, email directly)]

https://reviewboard.mozilla.org/r/23513/#review20959

I don't see a way to make GENERATED_FILES do the right thing for multiple outputs for a single invocation.

Comment 4

[Mike Hommey [:glandium]]

Yeah, indeed, you can't group output files...

Comment 5

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Comment 6

[Mike Hommey [:glandium]]

Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

https://reviewboard.mozilla.org/r/23513/#review21099

::: accessible/xpcom/AccEventGen.py:13
(Diff revision 2)
> +# The xpidl parser is not incorporated in the in-tree virtualenv.

Mmmmm there may not be a good reason for this anymore, but I'm not sure. Maybe file a followup to figure out whether to add in to the virtualenv and remove this?

::: accessible/xpcom/AccEventGen.py:18
(Diff revision 2)
> +p = xpidl.IDLParser()

Please also move the "Initialize the parser" comment alongside.

::: accessible/xpcom/AccEventGen.py:215
(Diff revision 2)
> +            set([mozpath.join(xpidl_dir, f) for f in ('header.py', 'xpidl.py')]))

This shouldn't be needed, but it currently is, and that sucks. Considering the problem applies to more than this script, I'm tempted to say: don't add those manually, and fix file_generate to track the imported modules and add them to the dep_file. Can I convince you to do that?

Comment 7

[Chris Manchester (limited bugmail, email directly)]

https://reviewboard.mozilla.org/r/23513/#review21099

> This shouldn't be needed, but it currently is, and that sucks. Considering the problem applies to more than this script, I'm tempted to say: don't add those manually, and fix file_generate to track the imported modules and add them to the dep_file. Can I convince you to do that?

Sure, filed bug 1219521 for that.

Comment 8

[Trevor Saunders (:tbsaunde)]

Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

I'm not really sure why xpcAccEvents.h needs exported, we could try just not doing that.

Comment 9

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23513/diff/2-3/

Comment 10

[Chris Manchester (limited bugmail, email directly)]

Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

This is a trivial update for bug 1219521, carrying forward r+.

Comment 11

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b47f568585f2

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b47f568585f2