Closed Bug 1217015 Opened 4 years ago Closed 4 years ago

move xpcAccEvents.cpp to GENERATED_FILES

Categories

(Firefox Build System :: General, defect)

43 Branch
defect
Not set

Tracking

(firefox45 fixed)

RESOLVED FIXED
mozilla45
Tracking Status
firefox45 --- fixed

People

(Reporter: froydnj, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Once we can generate deps support, this will be easy(ier) and enable us to remove a Makefile.in.
Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in
Attachment #8679703 - Flags: review?(tbsaunde+mozbugs)
Attachment #8679703 - Flags: review?(mh+mozilla)
Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

https://reviewboard.mozilla.org/r/23513/#review20959

::: accessible/xpcom/AccEventGen.py:205
(Diff revision 1)
> -def main():
> -    from argparse import ArgumentParser
> +    sdk_path = mozpath.join(buildconfig.substs['LIBXUL_DIST'], 'sdk', 'bin')
> +    sys.path.append(sdk_path)

You can skip this. The whole business with LIBXUL_DIST/sdk/bin comes from --with-libxul-sdk builds, but that has been removed.

Which means you can include xpidl globally and don't need xpidl_attr_type anymore.

This should also simplify gen_file enough that you can just inline it in gen_header_file and gen_cpp_file.

That being said, I'm not sure it's wise to have the script be invoked twice instead of once.
Attachment #8679703 - Flags: review?(mh+mozilla)
https://reviewboard.mozilla.org/r/23513/#review20959

I don't see a way to make GENERATED_FILES do the right thing for multiple outputs for a single invocation.
Yeah, indeed, you can't group output files...
Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in
Attachment #8679703 - Flags: review?(mh+mozilla)
Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

https://reviewboard.mozilla.org/r/23513/#review21099

::: accessible/xpcom/AccEventGen.py:13
(Diff revision 2)
> +# The xpidl parser is not incorporated in the in-tree virtualenv.

Mmmmm there may not be a good reason for this anymore, but I'm not sure. Maybe file a followup to figure out whether to add in to the virtualenv and remove this?

::: accessible/xpcom/AccEventGen.py:18
(Diff revision 2)
> +p = xpidl.IDLParser()

Please also move the "Initialize the parser" comment alongside.

::: accessible/xpcom/AccEventGen.py:215
(Diff revision 2)
> +            set([mozpath.join(xpidl_dir, f) for f in ('header.py', 'xpidl.py')]))

This shouldn't be needed, but it currently is, and that sucks. Considering the problem applies to more than this script, I'm tempted to say: don't add those manually, and fix file_generate to track the imported modules and add them to the dep_file. Can I convince you to do that?
Attachment #8679703 - Flags: review?(mh+mozilla) → review+
https://reviewboard.mozilla.org/r/23513/#review21099

> This shouldn't be needed, but it currently is, and that sucks. Considering the problem applies to more than this script, I'm tempted to say: don't add those manually, and fix file_generate to track the imported modules and add them to the dep_file. Can I convince you to do that?

Sure, filed bug 1219521 for that.
Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

I'm not really sure why xpcAccEvents.h needs exported, we could try just not doing that.
Attachment #8679703 - Flags: review?(tbsaunde+mozbugs) → review+
Attachment #8679703 - Flags: review+ → review?(tbsaunde+mozbugs)
Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23513/diff/2-3/
Comment on attachment 8679703 [details]
MozReview Request: Bug 1217015 - Convert AccEventGen.py to GENERATED_FILES and get rid of most of accessible/xpcom/Makefile.in

This is a trivial update for bug 1219521, carrying forward r+.
Attachment #8679703 - Flags: review?(tbsaunde+mozbugs) → review+
https://hg.mozilla.org/mozilla-central/rev/b47f568585f2
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla45
Assignee: nobody → cmanchester
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.