Closed Bug 1217073 Opened 6 years ago Closed 6 years ago

Update restricted profile toggles to account for new settings organization

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

35 Branch
defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: Margaret, Assigned: Margaret)

References

Details

Attachments

(1 file)

I'm going to try my best to maintain the current restricted profile settings toggles as I implement the new settings organization in bug 1216257, but this reorganization actually invalidates some of our previous product decisions.

For example, we currently give admins the ability to disable the "Display" category, but that category is going away. Should I just remove the ability to disable this? Or do we want to disable some individual settings?

Barbara, could you help me by looking over the list in bug 1216257 and think about which settings we should allow admins to toggle?
Flags: needinfo?(bbermes)
We've met and agreed that for now, keep it simple and try to re-work what we have and then focus on https://bugzilla.mozilla.org/show_bug.cgi?id=1222390. Let me know if you need any other help or have any other comments.
Flags: needinfo?(bbermes)
Bug 1217073 - Update restricted profile toggles to account for new settings organization. r=sebastian
Attachment #8684448 - Flags: review?(s.kaspari)
A few things to note:

* I didn't change the values of the restriction constants, even though I removed unused ones, because I assumed those values are stored somewhere when the admin changes restrictions, and I don't want to need to migrate values for existing users.

* I had to keep some things around for guest profiles.

* I fixed a bug to remove the remote debugging "Learn more" link when remote debugging is disabled (this looks like an existing bug with guest profiles), and as part of this I decided that we really only need one of these links, since they point to the same place.
Duplicate of this bug: 1222425
Comment on attachment 8684448 [details]
MozReview Request: Bug 1217073 - Update restricted profile toggles to account for new settings organization. r=sebastian

https://reviewboard.mozilla.org/r/24573/#review22189

The patch misses an edge case: On small tablets (Nexus 7) the split pane is not used and we just show the normal list of settings. In this list "Advanced" is still accessible.

::: toolkit/components/parentalcontrols/nsIParentalControlsService.idl
(Diff revision 1)
> -  const short DEVELOPER_TOOLS = 12; // Web developer tools
> -  const short CUSTOMIZE_HOME = 13; // Customizing home panels
>    const short PRIVATE_BROWSING = 14; // Disallow usage of private browsing
>    const short LOCATION_SERVICE = 15; // Sharing of location data to location service
> -  const short DISPLAY_SETTINGS = 16; // Website display settings
>    const short CLEAR_HISTORY = 17; // Clear browsing history
>    const short MASTER_PASSWORD = 18; // Setting master password for logins
>    const short GUEST_BROWSING = 19; // Disallow usage of guest browsing
>    const short DEFAULT_THEME = 20; // Use default theme or a special parental controls theme
> +  const short ADVANCED_SETTINGS = 21; // Advanced settings

You can reuse the int values here and in Restriction.java (we did in the past). They only matter at runtime. The only stored value is the string (e.g. "no_advanced_settings") in the UserManager.
Attachment #8684448 - Flags: review?(s.kaspari)
Attachment #8684448 - Flags: review?(s.kaspari)
Comment on attachment 8684448 [details]
MozReview Request: Bug 1217073 - Update restricted profile toggles to account for new settings organization. r=sebastian

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/24573/diff/1-2/
Comment on attachment 8684448 [details]
MozReview Request: Bug 1217073 - Update restricted profile toggles to account for new settings organization. r=sebastian

https://reviewboard.mozilla.org/r/24573/#review22205
Attachment #8684448 - Flags: review?(s.kaspari) → review+
https://hg.mozilla.org/integration/fx-team/rev/4996460f3fc98e467eb8ceedfda9ed8216443276
Bug 1217073 - Update restricted profile toggles to account for new settings organization. r=sebastian
https://hg.mozilla.org/mozilla-central/rev/4996460f3fc9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.