Closed Bug 1217090 Opened 11 years ago Closed 10 years ago

change the button names on the 'finish review' dialog

Categories

(MozReview Graveyard :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: glob, Unassigned)

References

Details

on the 'finish review' dialog i think the names of the buttons are not clear -- the distinction between "publish" and "save" isn't clear given you've already indicated that you want to "finish" the review (which implies publishing). currently we have: "Publish Review" "Discard Review" "Cancel" "Save" i think these names would be clearer: "Publish Review" "Discard Review" (delete this button) "Revert" "Close"
Blocks: 1246611
See Also: → 1247744
Product: Developer Services → MozReview
FWIW I don't think I pressed the right button in this dialog one single time. Usually I notice when my review queue hasn't changed size… I don't know why the state isn't autosaved in the background, so you only need a button to publish, and one to back out of the dialog (clearing the "Ship It", if set).
So this was improved in Review Board 2.5: https://www.reviewboard.org/docs/releasenotes/reviewboard/2.5/#improvements-to-the-review-dialog The buttons are now "Publish Review", "Discard Review", and "Close". In addition, the fields are autosaved now. This means there is no way to discard changes to a review in progress (as would have been done if "Cancel" had been clicked before), but overall I think this is a big win, so I'm going to close this and the related bug out.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.