Closed Bug 1247744 Opened 10 years ago Closed 10 years ago

Finalize-review dialog: rename "Save" to "Save Draft" and replace "Cancel" with a dialog-close control

Categories

(MozReview Graveyard :: Review Board: User Interface, defect, P1)

Production
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: mcote, Unassigned)

References

Details

Selena just suggested that we rename "Save" to "Save Draft". This makes the intention, and the difference between "Publish" and "Save", much clearer. Also, Tiffanie recommended removing the "Cancel" button and just putting in a simple, standard dialog-close "X" button in the corner. I think both these ideas are fabulous and pretty easy. Might be best to fix them upstream, if they are interested (and if we can get a release before too long).
Another idea (not certain, but worth considering) is also removing the "Discard Review" button and instead doing something like popping up a dialog with a checkbox beside "Discard review" when someone clicks the "X" button to close the dialog. It would be an extra step to discard a review, but it would also remove yet another button. Possibly worth looking into how often reviews are discarded from that screen.
Upon further discussion with Selena, the idea in comment 1 is probably a bit too much, so let's just stick with the original idea for now.
Blocks: 1246611
See Also: → 1217090
Product: Developer Services → MozReview
Component: General → Review Board: User Interface
Priority: -- → P1
As mentioned in bug 1217090 comment 3, the review dialog was greatly improved in Review Board 2.5, so I think we're good here.
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.