1217358 - Parse Web Extensions' manifest.json on submission

Status: RESOLVED FIXED

(addons.mozilla.org Graveyard :: Developer Pages, defect)

Description

[Mathieu Agopian [:magopian]]

When submitting the add-on to AMO: we need a new "Extractor" subclass (https://github.com/mozilla/olympia/blob/a926e1d7f2323c778e638bf82483ae45372608f3/apps/files/utils.py#L86) to deal with the manifest.json format.

Comment 1

[Mathieu Agopian [:magopian]]

PR: https://github.com/mozilla/olympia/pull/839

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/olympia

https://github.com/mozilla/olympia/commit/2a91832145fd21e90a703dbf65015181b29f359c
Parse the WebExtension's manifest on submission (bug 1217358)

https://github.com/mozilla/olympia/commit/6bba63313faf0ace65073a2995f36a032a7e0ffe
Merge pull request #839 from magopian/1217358-parse-webextension-manifest-on-submission

Parse the WebExtension's manifest on submission (bug 1217358)

Comment 3

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-11-02 at 11.10.46.png - WebExtension accepted by AMO

The current work only allows the submission on AMO, but it's still rejected/unrecognized by the validator (this is bug 1217810).

See the attachment for an idea of what it should look like. I've also attached an example Webextension to this bug for testing.

For a comparison, see the other screenshot for how it looked before AMO would accept the submission of webextensions.

Comment 4

[Mathieu Agopian [:magopian]]

Attachment: Screen Shot 2015-11-02 at 11.12.04.png - WebExtension NOT accepted by AMO

Comment 5

[Mathieu Agopian [:magopian]]

Attachment: beastify.xpi - example WebExtension

Find some more example WebExtensions on https://github.com/mdn/webextensions-examples