Closed
Bug 1218482
Opened 8 years ago
Closed 8 years ago
[webvr] Enable WebVR By Default on all platforms
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
VERIFIED
FIXED
mozilla46
People
(Reporter: kip, Assigned: kip)
References
(Depends on 1 open bug, Blocks 1 open bug)
Details
(Keywords: dev-doc-complete, devrel-needed, Whiteboard: [webvr])
Attachments
(1 file, 2 obsolete files)
5.95 KB,
patch
|
Details | Diff | Splinter Review |
WebVR has been developed behind the dom.vr.enabled preference, but has not yet been enabled by default due to incompatibility with e10s. Bug 1182048 enables compatibility with e10s. Once Bug 1182048 lands, we wish to enable WebVR by default.
Assignee | ||
Comment 1•8 years ago
|
||
The patch changes two preferences: dom.vr.enabled is now "true" by default. dom.vr.add-test-devices is now "0" by default, so that content may detect VR devices accurately.
Assignee | ||
Comment 2•8 years ago
|
||
Bug 1218482 - Enable WebVR By Default - dom.vr.enabled is now "true" by default. - dom.vr.add-test-devices is now "0" by default, so that content may detect VR devices accurately.
Assignee | ||
Comment 3•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Bug 1218482 - Enable WebVR By Default - dom.vr.enabled is now "true" by default. - dom.vr.add-test-devices is now "0" by default, so that content may detect VR devices accurately.
Attachment #8679023 -
Flags: review?(vladimir)
Comment 4•8 years ago
|
||
Release Note Request (optional, but appreciated) [Why is this notable]: WebVR enabled by default [Suggested wording]: Use virtual reality devices with the web with the introduction of WebVR [Links (documentation, blog post, etc)]: http://mozvr.com/ http://webvr.info/
relnote-firefox:
--- → ?
Assignee | ||
Comment 5•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=b05f468cfb5b
Assignee | ||
Comment 6•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d468bfe3cf08
Updated•8 years ago
|
Keywords: dev-doc-needed
Updated•8 years ago
|
Keywords: devrel-needed
Assignee | ||
Comment 7•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Bug 1218482 - Enable WebVR By Default - dom.vr.enabled is now "true" by default. - dom.vr.add-test-devices is now "0" by default, so that content may detect VR devices accurately.
Assignee | ||
Comment 8•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Bug 1218482 - Enable WebVR By Default - dom.vr.enabled is now "true" by default. - dom.vr.add-test-devices is now "0" by default, so that content may detect VR devices accurately.
Attachment #8679023 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 9•8 years ago
|
||
As this functionality is not intended to land in Firefox 44, we will delay committing until after the Firefox 44 branch date and let it ride the trains to Firefox 45.
Assignee | ||
Comment 10•8 years ago
|
||
I have added bzbarsky to the reviewers for the patch, as it now includes an update to test_interfaces.html to confirm that there has been DOM peer review.
Updated•8 years ago
|
Whiteboard: [webvr]
![]() |
||
Comment 11•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion https://reviewboard.mozilla.org/r/23343/#review21111 I would really like to see answers to Ehsan's questions in the intent to ship thread before we ship this.
Attachment #8679023 -
Flags: review?(bzbarsky)
Assignee | ||
Comment 12•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d3e13538c0d2
Comment 13•8 years ago
|
||
Hmm, does "all platforms" include Android and b2g? It seems like those platforms don't need this enabled, so you should probably make the pref change in firefox.js.
Assignee | ||
Comment 14•8 years ago
|
||
(In reply to Ehsan Akhgari (don't ask for review please) [Away Nov 3-19] from comment #13) > Hmm, does "all platforms" include Android and b2g? It seems like those > platforms don't need this enabled, so you should probably make the pref > change in firefox.js. This does indeed include Android and B2G. Android can utilize VR through the Google "Cardboard VR" holders. I have not yet tested this with B2G; however, it should theoretically work as well. (I'll give it a try and report back)
Assignee | ||
Comment 15•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=8290d1551107
Assignee | ||
Comment 16•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=fbc92708bfcb
Assignee | ||
Comment 17•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7170c08a9780
Assignee | ||
Comment 18•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=c094db11e5d7
Assignee | ||
Comment 19•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=cabad74159c1
Assignee | ||
Comment 20•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7e3cbfc5f46d
Assignee | ||
Comment 21•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=270b42e18918
Assignee | ||
Comment 22•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=e2d31b9f5b86
Assignee | ||
Comment 23•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=64fc2b338ba4
Assignee | ||
Comment 24•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e2ab7bfe767
Assignee | ||
Comment 25•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=edb93b9936e7
Assignee | ||
Comment 26•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dd81fc38802e
Assignee | ||
Comment 27•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=dfee67957e54
Assignee | ||
Comment 28•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2d2b3ba460ed
Assignee | ||
Comment 29•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=7b663554f694
Assignee | ||
Comment 30•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23343/diff/2-3/
Attachment #8679023 -
Flags: review?(bugs)
Assignee | ||
Comment 31•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23343/diff/2-3/
Attachment #8679023 -
Flags: review?(bugs) → review?(bzbarsky)
Assignee | ||
Comment 32•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=782a6b3ae602
Assignee | ||
Comment 33•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23343/diff/2-3/
Assignee | ||
Comment 34•8 years ago
|
||
I have updated the (In reply to :Ehsan Akhgari from comment #13) > Hmm, does "all platforms" include Android and b2g? It seems like those > platforms don't need this enabled, so you should probably make the pref > change in firefox.js. I have updated the patches to enable the dom.vr.enable preference and the DOM interfaces in test_interfaces.html to enable WebVR by default for non-release builds only. Does this look good to you? Are there any other changes required?
Flags: needinfo?(ehsan)
Comment 35•8 years ago
|
||
Yes, this looks good! But your test_interfaces.html changes look wrong, you shouldn't need to set |android: true|.
Flags: needinfo?(ehsan)
![]() |
||
Comment 36•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion https://reviewboard.mozilla.org/r/23343/#review23461 r=me
Attachment #8679023 -
Flags: review?(bzbarsky) → review+
Assignee | ||
Comment 37•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23343/diff/3-4/
Attachment #8679023 -
Flags: review?(vladimir)
Assignee | ||
Comment 38•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=3906a91f7607
Assignee | ||
Comment 39•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=313cd56518d7
Updated•8 years ago
|
status-firefox44:
affected → ---
Assignee | ||
Comment 40•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/3769091b5a3edd3f86ccbe372d9f5c0215d14d3a Bug 1218482 - Enable WebVR By Default,r=bz
Comment 41•8 years ago
|
||
Backed out in https://hg.mozilla.org/integration/mozilla-inbound/rev/46da19b55672 for "Assertion failure: mCompositorThreadHolder, at /builds/slave/b2g_m-in_emu-d_dep-00000000000/build/gecko/gfx/vr/ipc/VRManagerParent.cpp:109" in a wide variety of b2g emulator mochitests.
Comment 42•8 years ago
|
||
A wide variety of which I could have pasted representative logs, yes. https://treeherder.mozilla.org/logviewer.html#?job_id=19095862&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=19095860&repo=mozilla-inbound https://treeherder.mozilla.org/logviewer.html#?job_id=19090063&repo=mozilla-inbound
Assignee | ||
Comment 43•8 years ago
|
||
Comment on attachment 8679023 [details] MozReview Request: Bug 1218482 - Remove unnecessary assertion Review request updated; see interdiff: https://reviewboard.mozilla.org/r/23343/diff/3-4/
Attachment #8679023 -
Attachment description: MozReview Request: Bug 1218482 - Enable WebVR By Default → MozReview Request: Bug 1218482 - Remove unnecessary assertion
Assignee | ||
Updated•8 years ago
|
Attachment #8679023 -
Flags: review+
Assignee | ||
Comment 44•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=614a421b74d2
Assignee | ||
Comment 45•8 years ago
|
||
Running B2G Emulator Mochitests on Try to ensure that this is the extent of the issues.
Assignee | ||
Comment 46•8 years ago
|
||
Attachment #8679023 -
Attachment is obsolete: true
Assignee | ||
Comment 47•8 years ago
|
||
Removed an unnecessary assertion that was erroneously triggering on shutdown in B2G Mochitests.
Assignee | ||
Comment 48•8 years ago
|
||
Comment on attachment 8703008 [details] [diff] [review] Bug 1218482 - Remove unnecessary assertion This patch has been moved to Bug 1235803
Attachment #8703008 -
Attachment is obsolete: true
Assignee | ||
Comment 49•8 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/591f1064b73c05bc20f18801c1c369dc3403d0d2 Bug 1218482 - Enable WebVR By Default,r=bz
Assignee | ||
Comment 50•8 years ago
|
||
As Bug 1235803 and Bug 1235740 have landed, now re-landing this one.
Comment 51•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/591f1064b73c
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox46:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla46
Comment 52•8 years ago
|
||
Confirming that WebVR is now enabled by default across platforms (Win 10 x64, Ubuntu 14.04 x86 and Mac OS X 10.9.5), using latest 46 Nightly, build ID: 20160105030211.
Status: RESOLVED → VERIFIED
Kip, is there a blog post or something I can link to for the aurora release notes?
Flags: needinfo?(kgilbert)
Comment 54•8 years ago
|
||
Liz: you could link to the MDN docs: https://developer.mozilla.org/en-US/docs/Web/API/WebVR_API
Comment 55•8 years ago
|
||
Browser compat data now updated on all the WebVR API ref pages: https://developer.mozilla.org/en-US/docs/Web/API/WebVR_API Also, I want to confirm that this is noted on the developer release notes: https://developer.mozilla.org/en-US/Firefox/Releases/46#New_APIs On a separate note, I've noticed that the MDN ref docs are now out-of-date with the spec; this will be updated once we have spare cycles to do so, probably in Q2.
Keywords: dev-doc-needed → dev-doc-complete
Comment 56•8 years ago
|
||
I have a question here: is the implementation out-of-date with the MDN ref docs? We have not seen requests for changes in our weekly doc request triage meetings.
Comment 57•8 years ago
|
||
(In reply to Jean-Yves Perrier [:teoli] from comment #56) > I have a question here: is the implementation out-of-date with the MDN ref > docs? We have not seen requests for changes in our weekly doc request triage > meetings. This is a good point. I am assuming we'd be up to date with the latest spec, which is not necessarily going to be the case ;-)
Assignee | ||
Comment 58•8 years ago
|
||
(In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #57) > (In reply to Jean-Yves Perrier [:teoli] from comment #56) > > I have a question here: is the implementation out-of-date with the MDN ref > > docs? We have not seen requests for changes in our weekly doc request triage > > meetings. > > This is a good point. I am assuming we'd be up to date with the latest spec, > which is not necessarily going to be the case ;-) A brief scan through the current MDN docs appears to match the implementation. It should be noted; however, that the current API that is implemented will be deprecated soon in favor of the compatibility-breaking "WebVR 1.0" api: https://mozvr.github.io/webvr-spec/ The dust is still settling on "WebVR 1.0" as it has just been released publicly for feedback. Our implementation of this API is tracked in Bug 1250244. This is expected to land within one quarter. Please NI me if you would like more details.
Flags: needinfo?(kgilbert)
Comment 59•8 years ago
|
||
(In reply to :kip (Kearwood Gilbert) from comment #58) > (In reply to Chris Mills (Mozilla, MDN editor) [:cmills] from comment #57) > > (In reply to Jean-Yves Perrier [:teoli] from comment #56) > > > I have a question here: is the implementation out-of-date with the MDN ref > > > docs? We have not seen requests for changes in our weekly doc request triage > > > meetings. > > > > This is a good point. I am assuming we'd be up to date with the latest spec, > > which is not necessarily going to be the case ;-) > > A brief scan through the current MDN docs appears to match the > implementation. > > It should be noted; however, that the current API that is implemented will > be deprecated soon in favor of the compatibility-breaking "WebVR 1.0" api: > > https://mozvr.github.io/webvr-spec/ > > The dust is still settling on "WebVR 1.0" as it has just been released > publicly for feedback. Our implementation of this API is tracked in Bug > 1250244. This is expected to land within one quarter. Please NI me if you > would like more details. Thanks for the info kip — I think we should be ok at this point; I've put WebVR docs update into our publishing pipeline for Q2, and we've got the dev-doc-needed keyword set on the implementation bug, so it will come up in our triage list when the work is complete. We might want to still touch base nearer the time to discuss a schedule for getting the doc updates published.
Comment 60•8 years ago
|
||
We should update the release notes as we disabled it because of bug 1239055
Comment 61•8 years ago
|
||
dev-doc-needed so that we undo what has been done in comment 55 :-(
Keywords: dev-doc-complete → dev-doc-needed
Comment 63•8 years ago
|
||
Kip: which bug should the writers follow to be notified when WebVR will be re-enabled by default?
Flags: needinfo?(kgilbert)
Assignee | ||
Comment 64•8 years ago
|
||
(In reply to Jean-Yves Perrier [:teoli] from comment #63) > Kip: which bug should the writers follow to be notified when WebVR will be > re-enabled by default? FYI - WebVR is still enabled by default in non-release builds. Once stability is improved, we still still want to wait for changes in the WebVR API to stabilize with WebVR 1.0. I have added Bug 1256444 to track the dependencies and enabling WebVR in release.
Flags: needinfo?(kgilbert)
Comment 65•8 years ago
|
||
Thanks a lot, :kip
Marking this as disabled for 46 since it will not be on by default on release next week.
You need to log in
before you can comment on or make changes to this bug.
Description
•