Closed Bug 1218557 Opened 6 years ago Closed 6 years ago

Update copy for settings re-org items

Categories

(Firefox for Android Graveyard :: Settings and Preferences, defect)

All
Android
defect
Not set
normal

Tracking

(firefox45 fixed)

RESOLVED FIXED
Firefox 45
Tracking Status
firefox45 --- fixed

People

(Reporter: antlam, Assigned: Margaret)

References

Details

Attachments

(1 file)

In bug 1216257 we reorganized things. 

Let's do a quick pass at updating some of the copy we identified as "quick wins" from Gemma's research.

This includes: 
---
 - Clear private data now -> "Clear Private Data"
 - Title bar -> "URL bar"
 - Clear on exit -> "Clear private data on exit"
 - Import from Android -> "Import options"
 - Download updates automatically -> "Automatic updates"
 - Tabs -> "Restore tabs"
 - Mozilla -> "Mozilla Firefox"
Flags: needinfo?(margaret.leibovic)
Do you have any feedback about the summary text under the categories as well?
Assignee: nobody → margaret.leibovic
Flags: needinfo?(margaret.leibovic) → needinfo?(alam)
I think those are going to be trickier. 

I like what you have now, it works pretty well. I like that format of listing the first couple of prefs that are in there. But I'm not sure how we're deciding what to list in the secondary/summary text area.

Is it possible to update these with just the first 3 or 4 prefs (whatever fits) from this reorg that are in that category? For Search, we could just stick with the current for now.
Flags: needinfo?(alam) → needinfo?(margaret.leibovic)
(In reply to Anthony Lam (:antlam) from comment #2)
> I think those are going to be trickier. 
> 
> I like what you have now, it works pretty well. I like that format of
> listing the first couple of prefs that are in there. But I'm not sure how
> we're deciding what to list in the secondary/summary text area.
> 
> Is it possible to update these with just the first 3 or 4 prefs (whatever
> fits) from this reorg that are in that category? For Search, we could just
> stick with the current for now.

Sure, we can do that.
Flags: needinfo?(margaret.leibovic)
Here's a build with the copy changes we discussed on IRC. Let me know if you'd like any changes, and I can post a patch for review once we're happy:
http://people.mozilla.org/~mleibovic/tmp/settings.apk
Flags: needinfo?(alam)
Awesome! Looks good Margaret.

But I didn't see "Import options" in "Advanced".. is that missing or did I just miss it?
Flags: needinfo?(alam) → needinfo?(margaret.leibovic)
(In reply to Anthony Lam (:antlam) from comment #5)
> Awesome! Looks good Margaret.
> 
> But I didn't see "Import options" in "Advanced".. is that missing or did I
> just miss it?

Which version of Android are you running? We hide that option on 6.0 (bug 1183559).
Flags: needinfo?(margaret.leibovic) → needinfo?(alam)
I still can't figure out how to create a separate mozreview request for a single patch that builds on top of another patch series, so doing this the old way.

This is built on top of the patches for bug 1220833.
Attachment #8683691 - Flags: review?(liuche)
Comment on attachment 8683691 [details] [diff] [review]
Update copy for settings reorg

Review of attachment 8683691 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/xml-v11/preferences_general_tablet.xml
@@ +34,5 @@
> +    <ListPreference android:key="browser.chrome.titlebarMode"
> +                    android:title="@string/pref_titlebar_mode"
> +                    android:entries="@array/pref_titlebar_mode_entries"
> +                    android:entryValues="@array/pref_titlebar_mode_values"
> +                    android:persistent="false" />

I should note: this change fixes a mistake I made in bug 1216257, where I accidentally removed the wrong pref from the tablet settings (we don't support the dynamic toolbar on tablets, but we *do* support the titlebar pref).
(In reply to :Margaret Leibovic from comment #6)
> (In reply to Anthony Lam (:antlam) from comment #5)
> > Awesome! Looks good Margaret.
> > 
> > But I didn't see "Import options" in "Advanced".. is that missing or did I
> > just miss it?
> 
> Which version of Android are you running? We hide that option on 6.0 (bug
> 1183559).

Ah, ok then. I tested it on my 6.0 device so that makes more sense.
Flags: needinfo?(alam)
Summary: Update copy for top level settings re-org items → Update copy for settings re-org items
Duplicate of this bug: 1222426
Comment on attachment 8683691 [details] [diff] [review]
Update copy for settings reorg

Review of attachment 8683691 [details] [diff] [review]:
-----------------------------------------------------------------

I noticed a few places where we use "title bar" in comments rather than "URL bar" but that's probably not a huge deal. Feel free to change them, or not (in that they are pretty inconsequential, but if they're going to be fixed at all, it should probably be in this bug).
Attachment #8683691 - Flags: review?(liuche) → review+
https://hg.mozilla.org/mozilla-central/rev/e2e7cd350ea9
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.