1218557 - Update copy for settings re-org items

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Settings and Preferences, defect)

Description

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

In bug 1216257 we reorganized things. 

Let's do a quick pass at updating some of the copy we identified as "quick wins" from Gemma's research.

This includes: 
---
 - Clear private data now -> "Clear Private Data"
 - Title bar -> "URL bar"
 - Clear on exit -> "Clear private data on exit"
 - Import from Android -> "Import options"
 - Download updates automatically -> "Automatic updates"
 - Tabs -> "Restore tabs"
 - Mozilla -> "Mozilla Firefox"

Comment 1

[:Margaret Leibovic]

Do you have any feedback about the summary text under the categories as well?

Comment 2

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

I think those are going to be trickier. 

I like what you have now, it works pretty well. I like that format of listing the first couple of prefs that are in there. But I'm not sure how we're deciding what to list in the secondary/summary text area.

Is it possible to update these with just the first 3 or 4 prefs (whatever fits) from this reorg that are in that category? For Search, we could just stick with the current for now.

Comment 3

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #2)
> I think those are going to be trickier. 
> 
> I like what you have now, it works pretty well. I like that format of
> listing the first couple of prefs that are in there. But I'm not sure how
> we're deciding what to list in the secondary/summary text area.
> 
> Is it possible to update these with just the first 3 or 4 prefs (whatever
> fits) from this reorg that are in that category? For Search, we could just
> stick with the current for now.

Sure, we can do that.

Comment 4

[:Margaret Leibovic]

Here's a build with the copy changes we discussed on IRC. Let me know if you'd like any changes, and I can post a patch for review once we're happy:
http://people.mozilla.org/~mleibovic/tmp/settings.apk

Comment 5

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

Awesome! Looks good Margaret.

But I didn't see "Import options" in "Advanced".. is that missing or did I just miss it?

Comment 6

[:Margaret Leibovic]

(In reply to Anthony Lam (:antlam) from comment #5)
> Awesome! Looks good Margaret.
> 
> But I didn't see "Import options" in "Advanced".. is that missing or did I
> just miss it?

Which version of Android are you running? We hide that option on 6.0 (bug 1183559).

Comment 7

[:Margaret Leibovic]

Attachment: Update copy for settings reorg

I still can't figure out how to create a separate mozreview request for a single patch that builds on top of another patch series, so doing this the old way.

This is built on top of the patches for bug 1220833.

Comment 8

[:Margaret Leibovic]

Comment on attachment 8683691 [details] [diff] [review]
Update copy for settings reorg

Review of attachment 8683691 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/resources/xml-v11/preferences_general_tablet.xml
@@ +34,5 @@
> +    <ListPreference android:key="browser.chrome.titlebarMode"
> +                    android:title="@string/pref_titlebar_mode"
> +                    android:entries="@array/pref_titlebar_mode_entries"
> +                    android:entryValues="@array/pref_titlebar_mode_values"
> +                    android:persistent="false" />

I should note: this change fixes a mistake I made in bug 1216257, where I accidentally removed the wrong pref from the tablet settings (we don't support the dynamic toolbar on tablets, but we *do* support the titlebar pref).

Comment 9

[Anthony Lam (:antlam) Find me, @antlam on Slack!]

(In reply to :Margaret Leibovic from comment #6)
> (In reply to Anthony Lam (:antlam) from comment #5)
> > Awesome! Looks good Margaret.
> > 
> > But I didn't see "Import options" in "Advanced".. is that missing or did I
> > just miss it?
> 
> Which version of Android are you running? We hide that option on 6.0 (bug
> 1183559).

Ah, ok then. I tested it on my 6.0 device so that makes more sense.

Comment 11

[Chenxia Liu [:liuche]]

Comment on attachment 8683691 [details] [diff] [review]
Update copy for settings reorg

Review of attachment 8683691 [details] [diff] [review]:
-----------------------------------------------------------------

I noticed a few places where we use "title bar" in comments rather than "URL bar" but that's probably not a huge deal. Feel free to change them, or not (in that they are pretty inconsequential, but if they're going to be fixed at all, it should probably be in this bug).

Comment 12

[:Margaret Leibovic]

https://hg.mozilla.org/integration/fx-team/rev/e2e7cd350ea934e8584413086c0e986df14904e0
Bug 1218557 - Update copy for settings reorg. r=liuche

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/e2e7cd350ea9