1218723 - [RTL][Settings]The parenthesis in "Data Settings" view are displayed incorrectly.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect, P1)

Description

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Settings_bracket.png

[1.Description]:
[RTL][Arieskk_v2.5][Flame_v2.5][Settings]Set your phone language to Arabic, Launch Settings -> Cellular & Data -> APN Settings , select any setting like Data Settings, the parenthesis are displayed incorrectly.
See attachment: Settings_bracket.png

[2.Testing Steps]: 
Premise: China unicom sim card is inserted in device.

1. Set your phone language to Arabic. 
2. Launch Settings app. 
3. Tap "Cellular & Data". 
4. Tap "APN Settings". 
5. Select any setting like Data Settings
6. Observe the list.


[3.Expected Result]: 
In step 6, the text should be shown in parenthesis.

[4.Actual Result]: 
In step 6, the parenthesis are displayed incorrectly.

[5.Reproduction build]: 
Device: AriesKK_2.5 [Affected]
Build ID               20151026223015
Gaia Revision          b564b21e08ffc3e4962f08850843c7482932ee7b
Gaia Date              2015-10-26 14:22:21
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6c7c983bce46a460c2766fbdd73283f6d2b03a69
Gecko Version          44.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151026.214940
Firmware Date          Mon Oct 26 21:49:48 UTC 2015
Bootloader             s1

Device: FlameKK_v2.5[Affected]
Build ID               20151026030217
Gaia Revision          a677ddd3aa3a81058775938bd56008d96dbc78b0
Gaia Date              2015-10-26 04:48:31
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/5ca03a00d26823ce91ee0eaa2937bed605bd53c1
Gecko Version          44.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151026.070911
Firmware Date          Mon Oct 26 07:09:23 EDT 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0


[6.Reproduction Frequency]: 
Always Recurrence,5/5

[7.TCID]: 
15673

Comment 1

[pelloux]

Self-assigning, I'm working on a fix.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1218723-settings-apn-parenthesis > mozilla-b2g:master

Comment 3

[pelloux]

Comment on attachment 8679931 [details] [review]
[gaia] Phoxygen:bug1218723-settings-apn-parenthesis > mozilla-b2g:master

Hi Fred, can you please review this PR?

Comment 4

[pelloux]

Thanks!

Comment 5

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/18b2721a711e78ccdaaaf21cf4dd145b1346f165

Comment 6

[Jenny (Leave from Mozilla)]

Attachment: Data Settings_master.png

This bug has been verified as pass on latest build of Flame KK master and Aries KK master by the STR in comment 0.
Actual results: The text is shown in parenthesis.
See attachment: Data Settings_master.png
Reproduce rate: 0/10.

Device: Flame KK master512MB (Pass)
Build ID               20151102150204
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/6275cd9c71b76891f6b6585dabc687bc443ab877
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151102.182914
Firmware Date          Mon Nov  2 18:29:28 EST 2015
Fireware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK master (Pass)
Build ID               20151103000930
Gaia Revision          7954ff0cbd794a35499a1082bed273598f82ee6f
Gaia Date              2015-11-02 17:35:17
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/9f69202d82752e093a653a8f15b0274e347db33a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151102.233051
Firmware Date          Mon Nov  2 23:30:58 UTC 2015
Bootloader             s1

Comment 7

[Augustin Trancart [:autra]]

Comment on attachment 8679931 [details] [review]
[gaia] Phoxygen:bug1218723-settings-apn-parenthesis > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): none
[User impact] if declined: bad user experience in RTL
[Testing completed]: not tested
[Risk to taking this patch] (and alternatives if risky): Low, only one css change.
[String changes made]: none

Comment 8

[Autumn.Qiu(Leave from Mozilla)]

This bug has been verified as pass on latest build of Flame KK 2.5 512mb and Aries KK 2.5 by the STR in comment 0.

Actual results: The text is shown in parenthesis.

See attachment: Verified_Aries_KK_v2.5_paren.png
Reproduce rate: 0/10.

Device: Aries KK 2.5(Pass)
Build ID               20151107112205
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         http://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151107.104119
Firmware Date          Sat Nov  7 10:41:27 UTC 2015
Bootloader             s1

Device: Flame KK 2.5 512MB(Pass)
Build ID               20151108004501
Gaia Revision          577948202ae12154524a2bd2bd6d467838ad50b8
Gaia Date              2015-11-07 10:00:59
Gecko Revision         https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/ae7b8b1fd9e1504347b938820f99d75058049386
Gecko Version          44.0a2
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151108.045623
Firmware Date          Sun Nov  8 04:56:35 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Comment 9

[Autumn.Qiu(Leave from Mozilla)]

Attachment: Verified_Aries_KK_v2.5_ paren.png.png

Comment 10

[Augustin Trancart [:autra]]

Comment on attachment 8679931 [details] [review]
[gaia] Phoxygen:bug1218723-settings-apn-parenthesis > mozilla-b2g:master

Already in 2.5.