1209978 - (Gaia RTL 2.5) CSS refactoring: Settings

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[gabriel]

Improve the RTL support of the Settings app by refactoring its stylesheets and supporting right-to-left navigation (prev/next buttons).

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master

Comment 2

[Fabien Cazenave [:kaze]]

Comment on attachment 8672420 [details] [review]
[gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master

Hi Evelyn, do you still review Settings patches? ;-)

Comment 3

[Evelyn Hung]

(In reply to Fabien Cazenave [:kaze] from comment #2)
> Comment on attachment 8672420 [details] [review]
> [gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master
> 
> Hi Evelyn, do you still review Settings patches? ;-)

I do when I have time. It's better to let Fred or other peers take over. :)

Comment 4

[[e-mail]]

Comment on attachment 8672420 [details] [review]
[gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master

Overall looks good with some nits. And you've addressed them during review time.
Thanks kaze!

Comment 5

[Fabien Cazenave [:kaze]]

Thanks for the quick and efficient review Fred!

Just squashed and merged: https://github.com/mozilla-b2g/gaia/commit/b64fc3d

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

I had to revert this in https://github.com/mozilla-b2g/gaia/commit/4a17ab672138c4ed9bc4cd510f071d5019eee662 for gij(14) failures like https://treeherder.mozilla.org/logviewer.html#?job_id=3006078&repo=b2g-inbound

Comment 7

[Fabien Cazenave [:kaze]]

Oh, my bad. Reopening.

Comment 8

[Fabien Cazenave [:kaze]]

Strange, treeherder was fine when I merged: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=0d5c4c11f7a1b5339110c6410722032fcf635127

Investigating…

Comment 9

[Augustin Trancart [:autra]]

Fabien is on PTO, so I'm taking this over.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] Phoxygen:bug1209978-settings_rtl_refacto > mozilla-b2g:master

Comment 11

[Augustin Trancart [:autra]]

Comment on attachment 8676068 [details] [review]
[gaia] Phoxygen:bug1209978-settings_rtl_refacto > mozilla-b2g:master

This patch is basically:
- Fabien's commit rebased on master
- a fix for the failing test

Fred, please r?

Comment 12

[[e-mail]]

The test looks fine, please resolve the conflict to merge the commits.

Comment 13

[[e-mail]]

Comment on attachment 8676068 [details] [review]
[gaia] Phoxygen:bug1209978-settings_rtl_refacto > mozilla-b2g:master

Thanks for taking care of it :)

Comment 14

[Augustin Trancart [:autra]]

My pleasure :-)

Comment 15

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/7570c8e5a3bd4f92f9365b7a1a16501d91d2d5ac