Closed Bug 1209978 Opened 6 years ago Closed 6 years ago

(Gaia RTL 2.5) CSS refactoring: Settings

Categories

(Firefox OS Graveyard :: Gaia::Settings, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(b2g-master fixed)

RESOLVED FIXED
FxOS-S10 (30Oct)
Tracking Status
b2g-master --- fixed

People

(Reporter: gabriel, Assigned: autra)

References

Details

Attachments

(2 files)

Improve the RTL support of the Settings app by refactoring its stylesheets and supporting right-to-left navigation (prev/next buttons).
Assignee: nobody → gabriel
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Assignee: gabriel → kaze
Depends on: 1209041
Comment on attachment 8672420 [details] [review]
[gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master

Hi Evelyn, do you still review Settings patches? ;-)
Attachment #8672420 - Flags: review?(ehung)
(In reply to Fabien Cazenave [:kaze] from comment #2)
> Comment on attachment 8672420 [details] [review]
> [gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master
> 
> Hi Evelyn, do you still review Settings patches? ;-)

I do when I have time. It's better to let Fred or other peers take over. :)
Attachment #8672420 - Flags: review?(ehung) → review?(gasolin)
Comment on attachment 8672420 [details] [review]
[gaia] fabi1cazenave:settings-bug1209978 > mozilla-b2g:master

Overall looks good with some nits. And you've addressed them during review time.
Thanks kaze!
Attachment #8672420 - Flags: review?(gasolin) → review+
Thanks for the quick and efficient review Fred!

Just squashed and merged: https://github.com/mozilla-b2g/gaia/commit/b64fc3d
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Oh, my bad. Reopening.
Status: RESOLVED → REOPENED
Flags: needinfo?(kaze)
Resolution: FIXED → ---
Assignee: kaze → augustin.trancart
Fabien is on PTO, so I'm taking this over.
Comment on attachment 8676068 [details] [review]
[gaia] Phoxygen:bug1209978-settings_rtl_refacto > mozilla-b2g:master

This patch is basically:
- Fabien's commit rebased on master
- a fix for the failing test

Fred, please r?
Attachment #8676068 - Flags: review?(gasolin)
The test looks fine, please resolve the conflict to merge the commits.
Comment on attachment 8676068 [details] [review]
[gaia] Phoxygen:bug1209978-settings_rtl_refacto > mozilla-b2g:master

Thanks for taking care of it :)
Attachment #8676068 - Flags: review?(gasolin) → review+
My pleasure :-)
Keywords: checkin-needed
https://github.com/mozilla-b2g/gaia/commit/7570c8e5a3bd4f92f9365b7a1a16501d91d2d5ac
Status: REOPENED → RESOLVED
Closed: 6 years ago6 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → FxOS-S10 (30Oct)
Depends on: 1218723
No longer depends on: 1218728
No longer depends on: 1218723
No longer depends on: 1218730
No longer depends on: 1218731
No longer depends on: 1218733
You need to log in before you can comment on or make changes to this bug.