1219151 - [TV Data Sync] Missing bookmark after synchronization

Status: RESOLVED WORKSFORME

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P1)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: Bookmark_Sync

The bookmark data is wrong after syncing bookmarks. Please see the video.

Test Account: [e-mail]

============== Gaia Information ==============
commit ed9f29f7da11370b7c9c4a9cf3d11139537539df
Merge: 70faabf 5df0f5a
Author: tamarahills <[e-mail]>
Date:   Tue Oct 27 21:58:46 2015 -0400

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

It seems that there is one missing bookmark: http://www.khi.url.tw/job.html

Comment 2

[Fernando Jiménez Moreno [:ferjm]]

This is weird.

I see this on the log:

PAYLOAD {"id":"zEgr9Ab9fSlN","type":"item","deleted":true}
PAYLOAD {"id":"XqpLY5q0HVZp","type":"bookmark","title":"http://www.khi.url.tw/job.htm","parentName":"Reading List (From Safari)","bmkUri":"http://www.khi.url.tw/job.htm","tags":[],"keyword":null,"description":null,"loadInSidebar":false,"parentid":"zEgr9Ab9fSlN"}

Note the parentid and the previous deletion.

I checked that this is properly synchronized on Firefox for iOS and on Desktop.

Sean, Michiel, any idea of what's going on here? Could this be a Syncto issue adding the "deleted" flag wrongly?

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

And the parentid doesn't seem to be correct. On Desktop this entry is shown under the 'Bookmarks Menu' folder, so the parentid should be "menu", just like other entries:

PAYLOAD {"id":"WxX96hErfieI","type":"separator","parentName":"Bookmarks Menu","pos":11,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"u2V863pYlQdJ","type":"bookmark","title":"https://www.mozilla.org/en-US/job.htm","parentName":"Bookmarks Menu","bmkUri":"https://www.mozilla.org/en-US/job.htm","tags":[],"keyword":null,"description":"","loadInSidebar":false,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"LXXVndXgELtG","type":"bookmark","title":"BBC - Homepage","parentName":"Bookmarks Menu","bmkUri":"http://www.bbc.com/","tags":[],"keyword":null,"description":"Breaking news, sport, TV, radio and a whole lot more. The BBC informs, educates and entertains - wherever you are, whatever your age.","loadInSidebar":false,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"bLloBLhMJXEC","type":"bookmark","title":"ITV Player homepage - ITV Player","parentName":"Bookmarks Menu","bmkUri":"https://www.itv.com/itvplayer/","tags":[],"keyword":null,"description":"Watch your favourite TV programmes live online, on Apple, Android and digital with the official CITV and ITV Player. The X Factor, Im a Celebrity, Breathless, Poirot, Coronation Street, Emmerdale, Exclusive Premieres and more...","loadInSidebar":false,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"1dQuavkDa_ZW","type":"folder","parentName":"Bookmarks Menu","title":"Online TV","description":null,"children":["HPrY2U5b2b-m","KZOPgub29Fnr","NVP5GXTCbYJx","7AxyO6CDikBd"],"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"TaWtTs_ogn5W","type":"separator","parentName":"Bookmarks Menu","pos":5,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"jGAE64GdJ1Ks","type":"bookmark","title":"MozTrap | Edit Case","parentName":"Bookmarks Menu","bmkUri":"https://moztrap.mozilla.org/manage/caseversion/184249/?from=/manage/cases/%3Ffilter-suite%3D907","tags":[],"keyword":null,"description":"Mozilla's open-source distributed test case management system","loadInSidebar":false,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"vuB2CNwU5e_O","type":"separator","parentName":"Bookmarks Menu","pos":7,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"vkCXDOR-rDQu","type":"query","queryId":"RecentTags","title":"Recent Tags","parentName":"Bookmarks Menu","bmkUri":"place:type=6&sort=14&maxResults=10","tags":[],"keyword":null,"description":null,"loadInSidebar":false,"parentid":"menu"} bookmarks.js:282:1
PAYLOAD {"id":"oPm4T1tXCLeb","type":"query","queryId":"RecentlyBookmarked","title":"Recently Bookmarked","parentName":"Bookmarks Menu","bmkUri":"place:folder=BOOKMARKS_MENU&folder=UNFILED_BOOKMARKS&folder=TOOLBAR&queryType=1&sort=12&maxResults=10&excludeQueries=1","tags":[],"keyword":null,"description":null,"loadInSidebar":false,"parentid":"menu"}


This is how it looks on Desktop:

https://gyazo.com/6af2aea40dbd2e00848fc5f77b390ea8

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Cynthia, did you do anything special with this entry? (http://www.khi.url.tw/job.htm) Like removing it and adding it again or something like that?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

^

Comment 6

[Cynthia Tang [:cynthiatang]]

Sorry, I am not sure. It's a test account. I can sync it from A desktop to B laptop. But I don't know why it does not work to TV. This is weird!

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #4)
> Cynthia, did you do anything special with this entry?
> (http://www.khi.url.tw/job.htm) Like removing it and adding it again or
> something like that?

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Attachment: Screen Shot 2015-10-29 at 09.38.30.png

When I use the following gaia version, 'http://www.khi.url.tw/job.html' exists in 'Bookmarks Menu'.

commit 1175cde3c59d0de6c6ce7ee2cbadda6667e52e05
Merge: 5a1c586 c70fed8
Author: Martijn <[e-mail]>
Date:   Wed Oct 28 10:52:46 2015 +0100

    Merge pull request #32717 from mwargers/1217485

    Bug 1217485 - Make various methods in cards_view part of class Card instead of class CardsView

Comment 8

[Sean Lee [:seanlee][:weilonge]]

'http://www.khi.url.tw/job.html' still exists in 'Bookmarks Menu' when I use the commit that Cynthia tired.

============== Gaia Information ==============
commit ed9f29f7da11370b7c9c4a9cf3d11139537539df
Merge: 70faabf 5df0f5a
Author: tamarahills <[e-mail]>
Date:   Tue Oct 27 21:58:46 2015 -0400

Does anyone add the record back or modify any bookmarks after filing the bug?

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

I cannot reproduce with the latest master either. Could this be a Syncto issue?

Comment 10

[Fernando Jiménez Moreno [:ferjm]]

So now the entry looks like this:

PAYLOAD {"id":"XqpLY5q0HVZp","type":"bookmark","title":"http://www.khi.url.tw/job.htm","parentName":"Bookmarks Menu","bmkUri":"http://www.khi.url.tw/job.htm","tags":[],"keyword":null,"description":null,"loadInSidebar":false,"parentid":"menu"}

Same id different parentid.

Weird.

Comment 11

[Michiel de Jong [:michielbdejong]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #9)
> I cannot reproduce with the latest master either. Could this be a Syncto
> issue?

Right, that would be explainable if you:
* Sync from this account before that bookmark was created
* Sync from another account
* Sync from this account again after that bookmark was created

But this bug was reported on 2015-10-28 00:30:33 PDT and the new Syncto server was deployed 16 hours before that, on Tue, 27 Oct 2015 08:33:33 -0700 (PDT).

Comment 12

[Michiel de Jong [:michielbdejong]]

(In reply to Michiel de Jong [:michielbdejong] from comment #11)
> But this bug was reported on 2015-10-28 00:30:33 PDT and the new Syncto
> server was deployed 16 hours before that, on Tue, 27 Oct 2015 08:33:33 -0700
> (PDT).

Ah, but we on the client-side we only started using the new BucketId 14 hours ago. https://github.com/mozilla-b2g/gaia/pull/32826

So yes, it would be good to try to reproduce this again, with current gaia master.

Comment 13

[Michiel de Jong [:michielbdejong]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #10)
> Same id different parentid.

If the parentid was wrong previously then it makes sense that the bookmark didn't show up, because we probably only display the ones that are findable through the parent/child tree?

Comment 14

[Fernando Jiménez Moreno [:ferjm]]

Yeah, but why was the parentid wrong? :)

Comment 15

[Fernando Jiménez Moreno [:ferjm]]

Unfortunately, I am not able to reproduce this anymore. I am going to close this one as worksforme. If anyone else is able to reproduce it, please reopen.

Comment 16

[Sean Lee [:seanlee][:weilonge]]

I will go back to this if this issue could be reproduced again.