1219275 - Session is not kept between reboots

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P1)

Description

[Fernando Jiménez Moreno [:ferjm]]

After a reboot with an already existing Sync session I see this on the logcat:

"Error trying sync unauthorized"

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

The 'unauthorized' error comes from the Sync app.

Comment 2

[Michiel de Jong [:michielbdejong]]

I see two problems:
* The IAC request not even reaching bootstrap.js. This is fixed when I put a delay at line 675 of tv_apps/smart-system/js/sync_manager.js, like this:

-      return this.iacRequest({
+      return new Promise(resolve => {
+        setTimeout(resolve, 10000);
+      }).then(() => {
+        return this.iacRequest({
[...]

* The unauthorized error. The only difference between the requests that are sent on boot and the ones that are sent during normal operation is that the BrowserID assertion of the failing ones sent on boot are 24 characters shorter. Do they have a wrong audience maybe?

Comment 3

[Michiel de Jong [:michielbdejong]]

Confirmed: During boot, `this.settings.get('sync.fxa.audience')` is `undefined` instead of the desired `'https://token.services.mozilla.com/'`, on this line: https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/sync_manager.js#L565

Comment 4

[Michiel de Jong [:michielbdejong]]

That, together with the fact that the sync app didn't start listening for the IAC request yet. Should be solvable with a setTimeout?

Comment 5

[Fernando Jiménez Moreno [:ferjm]]

Thanks for looking into this.

(In reply to Michiel de Jong [:michielbdejong] from comment #3)
> Confirmed: During boot, `this.settings.get('sync.fxa.audience')` is
> `undefined` instead of the desired `'https://token.services.mozilla.com/'`,
> on this line:
> https://github.com/mozilla-b2g/gaia/blob/master/tv_apps/smart-system/js/
> sync_manager.js#L565

Ugh, we have to wait until having observed all the settings then.

(In reply to Michiel de Jong [:michielbdejong] from comment #4)
> That, together with the fact that the sync app didn't start listening for
> the IAC request yet. Should be solvable with a setTimeout?

This should be handled by the IAC API... I'll take a look.

Comment 6

[Michiel de Jong [:michielbdejong]]

(In reply to Fernando Jiménez Moreno [:ferjm] from comment #5)
> This should be handled by the IAC API... I'll take a look.

It didn't happen every time, and I also didn't find a pattern in it. But sometimes I saw error 'undefined' instead of 'unauth', and from my debug output it seems that https://github.com/mozilla-b2g/gaia/blob/master/apps/sync/js/bootstrap.js#L105 was not reached in those cases. When I added the timeout, it stopped happening (but the other error stayed).

Comment 7

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1219275.sync.session > mozilla-b2g:master

Comment 8

[Michiel de Jong [:michielbdejong]]

Comment on attachment 8680642 [details] [review]
[gaia] ferjm:bug1219275.sync.session > mozilla-b2g:master

This still doesn't ensure that the sync app's bootstrap.js has been parsed and executed, maybe we should keep a follow-up bug open about that in case it becomes reproducible on other machines than mine.

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

(In reply to Michiel de Jong [:michielbdejong] from comment #8)
> Comment on attachment 8680642 [details] [review]
> [gaia] ferjm:bug1219275.sync.session > mozilla-b2g:master
> 
> This still doesn't ensure that the sync app's bootstrap.js has been parsed
> and executed, maybe we should keep a follow-up bug open about that in case
> it becomes reproducible on other machines than mine.

Why do we need that?

The IAC API takes care of waiting for the connection handler to be set before delivering the message. If this is not happening, that's an IAC or System Messages API bug.

Comment 11

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/6da0ea1cafac91057e6dcd0c7205f3dcdefcec6b

Comment 12

[Michiel de Jong [:michielbdejong]]

OK, tested again in master and could not reproduce it anymore. It was probably due to uncommitted changes I had in the sync app code.