1219631 - Implement *test_browser_share_link.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Browser, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/browser/test_browser_share_link.py

Comment 1

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1219631-share-test > mozilla-b2g:master

Comment 2

[Alberto Pastor [:albertopq]]

Comment on attachment 8696232 [details] [review]
[gaia] albertopq:1219631-share-test > mozilla-b2g:master

Jayme, could you please review that it covers the same case than the original one? Thanks!

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Comment on attachment 8696232 [details] [review]
[gaia] albertopq:1219631-share-test > mozilla-b2g:master

As with bug 1219632, I believe this was meant to go to Johan not me.

Comment 4

[Alberto Pastor [:albertopq]]

That's right, sorry for the confusion Jayme!

Comment 5

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 8696232 [details] [review]
[gaia] albertopq:1219631-share-test > mozilla-b2g:master

Like in bug 1219632, the test looks okay to me regarding the existing style.

Also like there, we can hide the implementation details (the waits, and frame switches), to just have the user's intent. For example:  
>  test('share url', function() {
>    var url = server.url('windowopen.html');
> 
>    var browser = rocketbar.gotoBrowser(url);
>    var activityPicker = browser.shareLink();
>    var messageApp = activityPicker.chooseSms();
>    assert.equal(messagesApp.Composer.messageInput.text(), url);
>  });

Comment 6

[Alberto Pastor [:albertopq]]

Fixed readability and landed!

Thanks

master: https://github.com/mozilla-b2g/gaia/commit/e3e744f65a9235c1827ee98e42e22a56b74295b2