1219661 - Implement *test_gallery_share_picture.py* as an integration test in JavaScript

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Gallery, defect)

Description

[William Hsu [:whsu]]

https://github.com/mozilla-b2g/gaia/tree/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_share_picture.py

Comment 1

[Hema Koka [:hema]]

Probably already covered in Gallery Activity Test. Punam, please review and close. 

Thanks
Hema

Comment 2

[Punam Dahiya [:pdahiya]]

We have share activity test from full-screen view in place.

https://github.com/mozilla-b2g/gaia/blob/master/apps/gallery/test/marionette/activity_test.js#L113

The test in python in #comment 0 is testing share flow from select view and should be implemented in integration tests.

https://github.com/mozilla-b2g/gaia/blob/master/tests/python/gaia-ui-tests/gaiatest/tests/functional/gallery/test_gallery_share_picture.py#L36

Comment 3

[Punam Dahiya [:pdahiya]]

Another select view test case, that I can pick after testing gallery select view delete flow as part of Bug 1219657. Leaving it unassigned incase some one gets to it before me.

Comment 4

[GitHub Autolander Bot]

Attachment: [gaia] punamdahiya:Bug1219661 > mozilla-b2g:master

Comment 5

[Punam Dahiya [:pdahiya]]

Comment on attachment 8690951 [details] [review]
[gaia] punamdahiya:Bug1219661 > mozilla-b2g:master

Hi David

Setting review flag on attached Gij test converted from python test. 
SelectView > share image using share activity is new test added, PR is showing quite a few lines touched but that's mostly indentation because of new test suite created. 

I plan to extend test coverage by adding more tests that will cover selecting and sharing multiple image blobs. Please review. Thanks!

Comment 6

[David Flanagan [:djf]]

Comment on attachment 8690951 [details] [review]
[gaia] punamdahiya:Bug1219661 > mozilla-b2g:master

I left some optional suggestions and a question about something that puzzles me on github, but I'm okay with you landing this as-is, if you'd like.

Comment 7

[Punam Dahiya [:pdahiya]]

(In reply to David Flanagan [:djf] from comment #6)
> Comment on attachment 8690951 [details] [review]
> [gaia] punamdahiya:Bug1219661 > mozilla-b2g:master
> 
> I left some optional suggestions and a question about something that puzzles
> me on github, but I'm okay with you landing this as-is, if you'd like.

Thanks David for review. I have updated patch with your suggestions. I will land on master once treeherder is done running tests.

Comment 8

[Punam Dahiya [:pdahiya]]

Patch landed on master

https://github.com/mozilla-b2g/gaia/commit/97266c579c544f5ba57a701f39893cc86d46774a