1219717 - [gtk3, Ubuntu 12.04] URL/Search bars have wrong (dark) background

Status: VERIFIED FIXED

(Core :: Widget: Gtk, defect)

Description

[Martin Stránský [:stransky] (ni? me)]

+++ This bug was initially created as a clone of Bug #1211892 +++

follow up from Bug 1211892 comment 17. We should use correct background for text fields (sMozFieldBackground/sMozFieldText).

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: background.patch

WIP patch. need to be tested on Ubuntu 12.04, works fine on Fedora/Gtk 3.18.

Comment 2

[Karl Tomlinson (:karlt)]

Comment on attachment 8680657 [details] [diff] [review]
background.patch

Thanks.  Feel free to land this as "use GtkTextView for text colors" or similar, even if you don't get a chance to test on Ubuntu 12.04, because it is the right thing to do.

Comment 3

[Martin Stránský [:stransky] (ni? me)]

Attachment: ubuntu 12.04 with this patch

Ubuntu 12.04 looks fine with this patch. No big difference from Gtk2 version.

Comment 4

[Martin Stránský [:stransky] (ni? me)]

Attachment: patch for check-in

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=fc332babcff1

Comment 5

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/95e4a598daf7

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/95e4a598daf7

Comment 7

[Karl Tomlinson (:karlt)]

Blocking bug 1193807 to indicate that we should uplift this before shipping the GTK3 build.

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/95e4a598daf7

Comment 10

[Carsten Book [:Tomcat]]

removing the b2g 2.5 flag since this commit has been reverted due to an incorrect merge, sorry for the confusion

Comment 11

[Karl Tomlinson (:karlt)]

Comment on attachment 8681348 [details] [diff] [review]
patch for check-in

Approval Request Comment
[Feature/regressing bug #]: bug 1186229
[User impact if declined]:
The effects of this can range from unhelpful background colors on older Ubuntu
distributions
(http://i.imgur.com/3yRWX0Z.png reported in bug 1211892 comment 7.)
to completely unreadable text in other themes, include defaults of other
distributions (bug 1216246).
[Describe test coverage new/current, TreeHerder]:
None.  Colors depend on themes.
[Risks and why]: 
Some risk of ending up with inappropriate colors in some untested themes, but
I confident that the logic here should give us colors that are consistent with
GTK in more situations.
[String/UUID change made/needed]:
None.

Comment 12

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8681348 [details] [diff] [review]
patch for check-in

Theme changes for readability with gtk3, ok to uplift to aurora and beta.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/b883b0c1507c

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/a59d9d8978ad

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/b883b0c1507c

Comment 16

[Bogdan Maris, Desktop Test Engineering]

Reproduced the initial issue using an old Nightly build 2015-10-08, verified using Firefox 43 beta 3, latest Developer Edition 44.0a2 (Light Theme) and latest Nightly 45.0a1 on Ubuntu 12.04 32-bit.