Closed
Bug 1220089
Opened 9 years ago
Closed 9 years ago
History collection checkbox enabled although refresh auth didn't succeed
Categories
(Firefox OS Graveyard :: Sync, defect, P3)
Tracking
(b2g-v2.5 fixed)
RESOLVED
FIXED
FxOS-S10 (30Oct)
| Tracking | Status | |
|---|---|---|
| b2g-v2.5 | --- | fixed |
People
(Reporter: ferjm, Assigned: ferjm)
References
Details
(Whiteboard: [partner-cherry-pick])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
yifan
:
review+
mpotharaju
:
approval-gaia-v2.5+
|
Details | Review |
Even if the user closes the refresh auth dialog, we still keep the history checkbox checked. The setting is not changed though, so there's not a privacy issue, but an UI one.
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → ferjmoreno
Blocks: fxos-sync
Priority: -- → P3
Target Milestone: --- → FxOS-S10 (30Oct)
|
||
Comment 1•9 years ago
|
||
|
|
Assignee | |
Updated•9 years ago
|
Attachment #8681380 -
Flags: review?(yliao)
|
||
Comment 2•9 years ago
|
||
Comment on attachment 8681380 [details] [review]
[gaia] ferjm:bug1220117.history.setting.auth.ignored > mozilla-b2g:master
Thank you!
Attachment #8681380 -
Flags: review?(yliao) → review+
|
|
||
Comment 3•9 years ago
|
||
Comment on attachment 8681380 [details] [review]
[gaia] ferjm:bug1220117.history.setting.auth.ignored > mozilla-b2g:master
[Approval Request Comment]
[Bug caused by] (feature/regressing bug #):
[User impact] if declined: A user will not know the history sync request fails.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=38f0591378e6de9324014f213c267060da3f6972
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none
Attachment #8681380 -
Flags: approval-gaia-v2.5?
|
|
Assignee | |
Comment 4•9 years ago
|
||
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•9 years ago
|
Whiteboard: [partner-cherry-pick]
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8681380 [details] [review]
[gaia] ferjm:bug1220117.history.setting.auth.ignored > mozilla-b2g:master
Approved for 2.5 uplift.
Thanks
Attachment #8681380 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
||
Comment 6•9 years ago
|
||
This cause conflicts on uplifting to 2.5 - could you take a look and provide a 2.5 PR request ? Thanks!
Flags: needinfo?(ferjmoreno)
|
|
Assignee | |
Comment 7•9 years ago
|
||
This was fixed on 2.5 with bug 1220541
status-b2g-v2.5:
--- → fixed
Flags: needinfo?(ferjmoreno)
You need to log in
before you can comment on or make changes to this bug.
Description
•