1220541 - Require user authentication refresh when the bookmark collection checkbox is changed to true

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Sync, defect, P3)

Description

[yifan [:yifan][:yliao]]

The same for history collection.

Comment 1

[Fernando Jiménez Moreno [:ferjm]]

AFAIK this was only required for the history collection, since bookmarks wasn't considered as private data. Can we get input from Tori here, please?

Comment 2

[yifan [:yifan][:yliao]]

Yes, I asked her offline. We can double confirm with her.

Hi Tori, just want to make sure should we have the same behavior for bookmarks, thanks!

Comment 3

[Tori Chen [:tori]]

I prefer to ask password since bookmark is also private to some degree.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Ok, let's do it then :)

Comment 5

[GitHub Autolander Bot]

Attachment: [gaia] ferjm:bug1220541.bookmarks.collection.refresh.auth > mozilla-b2g:master

Comment 6

[yifan [:yifan][:yliao]]

Comment on attachment 8682039 [details] [review]
[gaia] ferjm:bug1220541.bookmarks.collection.refresh.auth > mozilla-b2g:master

Thank you! Just a little bit uncertain about the sucked mozId part. Please refer to the Github comment.

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/47da49f8206788d70d834c3a63d9245d50c89103