Closed
Bug 1220381
Opened 9 years ago
Closed 9 years ago
[TV][browser] Revise TV pocket menu item from "https://getpocket.com/ " to "https://getpocket.com/fxostv "
Categories
(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)
Tracking
(blocking-b2g:2.5+, feature-b2g:2.5+, b2g-v2.5 fixed, b2g-master fixed)
VERIFIED
FIXED
FxOS-S11 (13Nov)
People
(Reporter: jocheng, Assigned: danhuang)
References
Details
(Whiteboard: [partner-cherry-pick][ft:conndevices][partner-blocker])
Attachments
(1 file)
|
46 bytes,
text/x-github-pull-request
|
yifan
:
review+
jocheng
:
approval-gaia-v2.5+
|
Details | Review |
[TV][browser] Revise TV pocket menu item from "https://getpocket.com/" to "https://getpocket.com/fxostv"
|
Reporter | |
Updated•9 years ago
|
Target Milestone: --- → FxOS-S11 (13Nov)
|
Assignee | |
Updated•9 years ago
|
Assignee: nobody → dhuang
|
||
Comment 3•9 years ago
|
||
|
|
Assignee | |
Comment 4•9 years ago
|
||
Comment on attachment 8685261 [details] [review] [gaia] danhuang1202:1220381_revise_tv_pocket_menu_uri > mozilla-b2g:master Hi Yi-fan, please help me review. This patch revise pocket menu item's uri from 'https://getpocket.com/' to 'https://getpocket.com/fxostv'. Thanks.
Attachment #8685261 -
Flags: review?(yliao)
|
|
Reporter | |
Updated•9 years ago
|
Status: NEW → ASSIGNED
|
|
Reporter | |
Updated•9 years ago
|
feature-b2g: --- → 2.5+
|
||
Comment 5•9 years ago
|
||
Comment on attachment 8685261 [details] [review] [gaia] danhuang1202:1220381_revise_tv_pocket_menu_uri > mozilla-b2g:master Thank you!
Attachment #8685261 -
Flags: review?(yliao) → review+
|
|
Assignee | |
Comment 6•9 years ago
|
||
Thanks for the review! Merge in master: https://github.com/mozilla-b2g/gaia/commit/8267d89c81a4e3261afedfd798345196cffd03b1
|
|
Assignee | |
Comment 7•9 years ago
|
||
Comment on attachment 8685261 [details] [review] [gaia] danhuang1202:1220381_revise_tv_pocket_menu_uri > mozilla-b2g:master [Approval Request Comment] [Bug caused by] (feature/regressing bug #): Bug 1194109 [User impact] if declined: The pocket menu item would not direct to the tv optimize pocket website [Testing completed]:https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=16bb14a40dbab1128df7b68179837492b7f0cd51 [Risk to taking this patch] (and alternatives if risky): None [String changes made]: Yes
Attachment #8685261 -
Flags: approval-gaia-v2.5?
|
|
Assignee | |
Updated•9 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
|
|
Reporter | |
Updated•9 years ago
|
blocking-b2g: --- → 2.5+
|
|
Reporter | |
Comment 8•9 years ago
|
||
Comment on attachment 8685261 [details] [review] [gaia] danhuang1202:1220381_revise_tv_pocket_menu_uri > mozilla-b2g:master Approved, patch is required for TV 2.5 pocket integration.
Attachment #8685261 -
Flags: approval-gaia-v2.5? → approval-gaia-v2.5+
|
|
Reporter | |
Updated•9 years ago
|
status-b2g-v2.5:
--- → affected
status-b2g-master:
--- → fixed
|
||
Comment 9•9 years ago
|
||
for 2.5 https://github.com/mozilla-b2g/gaia/commit/093f368470e897fb30221fc85dbc195a2914a2eb
|
||
Comment 10•9 years ago
|
||
Verify this issue on the latest build. TV pocket menu item is "https://getpocket.com/fxostv". [Build Info] Environment: 2.6 Simulator gaia: https://github.com/mozilla-b2g/gaia/commit/a6ecae635719115aa72465efe522fdced3dd1d70 gecko: https://hg.mozilla.org/mozilla-central/rev/af6356a3e8c56036b74ba097395356d9c6e6c5a3
Status: RESOLVED → VERIFIED
You need to log in
before you can comment on or make changes to this bug.
Description
•