1220387 - markup view search autocomplete does not offer matching classes sometimes

Status: RESOLVED FIXED

(DevTools :: Inspector, defect, P2)

Description

[arni2033]

Attachment: testcase 1 - Tooltip from 'Search with CSS selectors' field doesn't display any suggestions if input starts with letter contains non-letter character.htm

STR:   (Win7_64, Nightly 45, 32bit, ID 20151029045227, new profile)
1. Open attached "testcase 1"
2. Open devtools -> Inspector, type "test" in the field "Search with CSS selectors"
3. Delete everything in the field "Search with CSS selectors".   Type there "testA"
4. Delete everything in the field "Search with CSS selectors".   Type there "test1"
5. Delete everything in the field "Search with CSS selectors".   Type there "test_"

Result:
 After Step 3 tooltip displays suggestion ".testA_major" and ".testA_secondary"
 After Steps 4 & 5 there's no suggestions

Expectations:
 After Steps 4 tooltip should display suggestions ".test1_major" and ".test1_secondary"
 After Steps 5 tooltip should display suggestions ".test_A_major" and ".test_A_secondary"

Comment 1

[Patrick Brosset <:pbro>]

Triaging (filter on CLIMBING SHOES).

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1220387 - [devtools] Turn SelectorAutocompleter into a proper ES6 class. r=#devtools.

Comment 4

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1220387 - [devtools] Use proper private properties/methods in SelectorAutocompleter. r=#devtools.

We can remove the markupmutation event listener as it was only setting
properties that weren't read anywhere in the class.

Comment 5

[Nicolas Chevobbe [:nchevobbe]]

Attachment: Bug 1220387 - [devtools] Fix markup view search autocomplete for classes with non-alpha chars. r=#devtools.

A test task is added to inspector_search-03.js (which is already testing classes
and id checks).
The part of the test that was triggering keyboard event and asserting the popup
content is moved to head.js since I'm planning to fix other bugs and this might
come handy.
We also take this as an opportinuty to cleanup the assertions a bit, and to add
the expected input value after the keybpress so the test is easier to follow.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/85a872dd671b
[devtools] Turn SelectorAutocompleter into a proper ES6 class. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/cde7661c67fe
[devtools] Use proper private properties/methods in SelectorAutocompleter. r=devtools-reviewers,ochameau.
https://hg.mozilla.org/integration/autoland/rev/497ac458568c
[devtools] Fix markup view search autocomplete for classes with non-alpha chars. r=devtools-reviewers,ochameau.

Comment 7

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/85a872dd671b
https://hg.mozilla.org/mozilla-central/rev/cde7661c67fe
https://hg.mozilla.org/mozilla-central/rev/497ac458568c