1220528 - Configure the default build flag FIREFOX_SYNC to ENABLE in v2.5 branch, TV only

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)

Description

[Sean Lee [:seanlee][:weilonge]]

Since FirefoxSync feature is a must in gaia v2.5, the default build flag FIREFOX_SYNC should be configured as ENABLE.

Comment 1

[Sean Lee [:seanlee][:weilonge]]

This will be only happened in v2.5 gaia branch.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVBrowser/master/Bug1220528 > mozilla-b2g:master

Comment 3

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

Thank you Sean, I added a comment to your PR.

Comment 5

[Sean Lee [:seanlee][:weilonge]]

Thank you Fernando! I will modify the patch. :)

Comment 6

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8681802 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5

Hey Ricky, Fernando, Could you give a review/feedback for this patch? Thank you!

Comment 7

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8681802 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5

LGTM. Thanks!

Comment 8

[Ricky Chien [:rickychien] (inactive)]

Comment on attachment 8681802 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5

Hmm... it looks good to me. thanks for separating device makefile, it will be useful for support various form factor in the future.

Comment 9

[Sean Lee [:seanlee][:weilonge]]

After verifying the patch at bug 1216394, it does fix the issue.

Comment 10

[GitHub Autolander Bot]

Attachment: [gaia] weilonge:seanlee/TVBrowser/master/Bug1220528 > mozilla-b2g:master

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8681802 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): bug 1194108
[User impact] if declined: Developer has to use build flag FIREFOX_SYNC=1 to enable Firefox Sync feature in TV.
[Testing completed]: Tested in B2G Desktop
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 12

[Mahendra Potharaju [:mahe]]

Can you please update the bug to resolved and fixed, and I can approve the uplift. 

Thanks

Comment 13

[Mahendra Potharaju [:mahe]]

Comment on attachment 8681802 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/v2.5/Bug1220528 > mozilla-b2g:v2.5

Approved for 2.5 uplift

Comment 14

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/91e1047a80f1207c2af924a38f292141c647a250

btw, just in case, this never landed on gaia master so far (the 2nd Pull request) does this still need to land there ?

Comment 15

[Sean Lee [:seanlee][:weilonge]]

Hi Tomcat, Thanks for your remind. :) I think the patch for master is good enough to land. However, it still needs a r+.

Comment 16

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8684854 [details] [review]
[gaia] weilonge:seanlee/TVBrowser/master/Bug1220528 > mozilla-b2g:master

Hi Ricky, Could you help to review the patch for master? The difference with v2.5 one is only at FIREFOX_SYNC default value. Thank you!

Comment 17

[Sean Lee [:seanlee][:weilonge]]

landed on master: https://github.com/mozilla-b2g/gaia/commit/2bf719609b202e7e7d4d0d1cf17af0ecaaf021bc
gaia-test: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=5681115b1f02fb2d007f4338c74c09091ff2a367