1220605 - [TV Browser] The Browser Setting page disappears for a few seconds

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P3)

Description

[Cynthia Tang [:cynthiatang]]

Attachment: Video

STR:
 1. Launch Browser
 2. Sign in to Sync

Actual Result:
 - After typing the password and pressing enter, the Browser Setting page disappears for a few seconds. Please see the attachment. 

Expected Result:
 - After typing the password and pressing enter, the Browser Setting page should not disappear

Comment 1

[Josh Cheng [:josh]]

Hi Dan,
Over to you and feel free to reassign to Yifan if you like.

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1220605_the_browser_setting_page > mozilla-b2g:master

Comment 3

[yifan [:yifan][:yliao]]

Comment on attachment 8691761 [details] [review]
[gaia] begeeben:1220605_the_browser_setting_page > mozilla-b2g:master

This problem happens at the 1st time a user sign in the fx account from the toolbar. The patch opens the settings page at the background after a user clicks the sign in button on the toolbar. Thus when the sign in flow is finished, the settings page will be displayed.

Comment 4

[Fernando Jiménez Moreno [:ferjm]]

After bug 1219259 when Sync is enabled we don't show the settings panel but a popup letting the user know that Sync was enabled.

Tori, should we also show the settings panel when the user signs in from the toolbar and while Sync is enabling? Note that the settings panel won't be seen until the user finishes the FxA flow. So the UI flow when login from the toolbar would be something like:

1. Click on 'Sign in to Sync' will open the settings panel *and* the FxA flow. The FxA flow will be placed on top of the settings panel.
2. Once the user logs into FxA, the FxA flow will be hidden and the settings panel will be visible (with the 'Signing in...' label.
3. Eventually the popup informing about the enabled state will be shown. Dismissing the popup will show the settings panel again.

I am ok with this flow as it is similar to what happens when the user logs in from the settings panel instead of the toolbar, but I wanted to double check with you.

Comment 5

[Tori Chen [:tori]]

> 2. Once the user logs into FxA, the FxA flow will be hidden and the settings
> panel will be visible (with the 'Signing in...' label.
> 3. Eventually the popup informing about the enabled state will be shown.

I was thinking the part would be like this:
A spinner/loading icon on login button when the user signing in. Once it's finished, the pop-up show up. So the user will not see the setting panel after the user press login button.

"the FxA flow will be hidden and the settings panel will be visible, then bring up the pop-up" seems strange to me. 

> Dismissing the popup will show the settings panel again.

Isn't it "Dismissing the popup and return to previous browsing tab"? The behavior should be same as user login from the settings panel.

Overall, the difference between login from setting panel and toolbar should be only that login from toolbar will be lead to to FxA flow directly. 

Hope I am understanding it right:P

Comment 6

[Fernando Jiménez Moreno [:ferjm]]

Thank you Tori.

(In reply to Tori Chen [:tori] from comment #5)
> > 2. Once the user logs into FxA, the FxA flow will be hidden and the settings
> > panel will be visible (with the 'Signing in...' label.
> > 3. Eventually the popup informing about the enabled state will be shown.
> 
> I was thinking the part would be like this:
> A spinner/loading icon on login button when the user signing in.

We show the 'Signing in...' string in the toolbar login button, but it is not visible to the user until the FxA flow is closed.

> Once it's
> finished, the pop-up show up. So the user will not see the setting panel
> after the user press login button.
> 

No, with the attached patch, the user will see the settings panel *after* the FxA flow is closed.

Without the attached patch, the user will not see the settings panel at all, if the login was triggered from the toolbar.

> "the FxA flow will be hidden and the settings panel will be visible, then
> bring up the pop-up" seems strange to me. 
> 
> > Dismissing the popup will show the settings panel again.
> 
> Isn't it "Dismissing the popup and return to previous browsing tab"? The
> behavior should be same as user login from the settings panel.

1. If the login click happens from settings, the user will return to the settings panel after dismissing the popup.

2. If the login click happens from the toolbar:

2.1 With the attached patch, the user will return to the settings panel after dismissing the popup.
2.2 Without the attached patch, the user will return to previous browsing tab after dismissing the popup.

> 
> Overall, the difference between login from setting panel and toolbar should
> be only that login from toolbar will be lead to to FxA flow directly. 
>

In both cases we show the FxA flow directly.
 
> Hope I am understanding it right:P

It would be great if you could check the different behaviors with YiFan in real life :)

Comment 7

[Tori Chen [:tori]]

Thanks for explanation. It's clear to me now. 

> 1. If the login click happens from settings, the user will return to the settings panel after dismissing the popup.
> 2. If the login click happens from the toolbar:
> 2.1 With the attached patch, the user will return to the settings panel after dismissing the popup.
> 2.2 Without the attached patch, the user will return to previous browsing tab after dismissing the popup.

To be consistent, I'll vote 2.1. So your proposal (comment 4) is good to me.

Comment 8

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8691761 [details] [review]
[gaia] begeeben:1220605_the_browser_setting_page > mozilla-b2g:master

Thank you!

Comment 9

[Fernando Jiménez Moreno [:ferjm]]

https://github.com/mozilla-b2g/gaia/commit/97bd29ec28a873f694801d96546a0c7be02f690a

Comment 10

[yifan [:yifan][:yliao]]

Comment on attachment 8691761 [details] [review]
[gaia] begeeben:1220605_the_browser_setting_page > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: Sign in flow is not aligned to the spec
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=2ea8dc502071135f516677f7ce64f190157dd208
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 11

[Cynthia Tang [:cynthiatang]]

Hi Tori,
Please update UX spec for this change. If the visual spec should be update, please ni the visual expert. Thank you!

(In reply to Tori Chen [:tori] from comment #7)
> Thanks for explanation. It's clear to me now. 
> 
> > 1. If the login click happens from settings, the user will return to the settings panel after dismissing the popup.
> > 2. If the login click happens from the toolbar:
> > 2.1 With the attached patch, the user will return to the settings panel after dismissing the popup.
> > 2.2 Without the attached patch, the user will return to previous browsing tab after dismissing the popup.
> 
> To be consistent, I'll vote 2.1. So your proposal (comment 4) is good to me.

Comment 12

[Josh Cheng [:josh]]

Comment on attachment 8691761 [details] [review]
[gaia] begeeben:1220605_the_browser_setting_page > mozilla-b2g:master

Approve for TV 2.5

Comment 13

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/d6acb1b00c9a59811233b7490fd858a3471fe56e for 2.5

Comment 14

[Rid Pan]

Verify this issue on the latest build.
After typing the password and pressing done to sign in, the screen shows the Success Sign-in message. And then pressing the OK button will back to the Browser Setting page.
[Build Info]
Environment: 2.6 Simulator
gaia:
https://github.com/mozilla-b2g/gaia/commit/435a9320454ccc3ffdebff4d5d680f1254a15e26
gecko:
https://hg.mozilla.org/mozilla-central/rev/a9e33d8c48b5ca93ca1937eba4220f681a0f05ec

Comment 15

[Rid Pan]

The result of v2.5 is also passed.

[Build Info]
Environment: Simulator 2.5.20160215231509
gaia:
https://github.com/mozilla-b2g/gaia/commit/b059a19c4cb615e16174735662199e6769cee393
gecko:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/227c6d4926c154167a2214e123253f2c937e4106
mulet:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/9d519d3bedacb7f5ce467f4c6bef7ff55ff3b0f3