1220725 - Implement new type of icon in gaia-site-icon component, in order to render site icons

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::System, defect)

Description

[Alberto Pastor [:albertopq]]

Currently, gaia-site-icon [1] implements 2 types of icon:

- App: FirefoxOS apps we see in the homescreen
- Bookmarks: Pinned sites 

We would need a 3rd type of icon in order to be rendered in the browser chrome and Pin Dialogs. It should have the following features:

- Apply uniform favicon image treatment, like bookmarks do (depending on icon's size)
- Default icon image to avoid adding custom classes -> [2]

[1] https://github.com/gaia-components/gaia-site-icon
[2] https://github.com/mozilla-b2g/gaia/blob/master/apps/system/js/pin_page_system_dialog.js#L164

Comment 1

[Chris Lord [:cwiiis]]

I don't think we need a new type of icon here, we just need different behaviour for the existing bookmark icon type (which should probably be renamed at some point, along with the name of the element).

Basically you want bookmark icons to apply a default icon image when there's no icon available (which is what they used to do before we had to move the bookmark icon handling outside of gaia-site-icon). I think what we want to do is re-integrate bookmark icon handling into the component so that we can restore the old, desirable behaviour.

Comment 2

[Alberto Pastor [:albertopq]]

Yeah, changing the bookmark type works for me as well, but note that the default icon (when no icon is provided) for a bookmark in the homescreen is different than the one in chrome or Pin dialog.

Not sure what's the best way to implement this, but it would be great if you or :gmarty can take a look.

Comment 3

[Chris Lord [:cwiiis]]

It would be nice to be able to customise the default icons - I think you could do this now by changing the BaseURL property and then providing your own SVGs possible? But this would work across the whole page, which perhaps isn't ideal... Perhaps it would be good to have some signal-based API where you could override default images... Similarly, you'll want to be able to disable the icon subtitle.

I'm leaving n?me to see if I can get to this soon, but feel free to steal.

The design I envisage is something like this:

- Integrate IconsHelper into gaia-site-icon, reintegrate bookmark icon handling in gaia-site-icon
- Add a 'icon-alternative-requested' signal to allow users to override default icons
- Add a property ('display-title'?) to control visibility of icon subtitle

Comment 4

[Chris Lord [:cwiiis]]

Marking this as dependent on bug 1220186 as it'd be a huge pain to rebase either of these bugs I think (also, I think the work from that may make this easier).

Comment 5

[BMO Automation]

Firefox OS is not being worked on