1220860 - [AccessFu] Error (intermediate value).documentElement is undefined resource://gre/modules/accessibility/AccessFu.jsm:526

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect)

Description

[Yura Zenevich [:yzen] (please use "needinfo")]

In some cases documentElement is not available and causes an error.
Caused by bug 1214398

Comment 1

[Yura Zenevich [:yzen] (please use "needinfo")]

What this also results in is that Pointer Adapter is not shut down and thus even though the AccessFu is stopped, the pointer events are still blocked and the device is inoperable.

Comment 2

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1220860 patch

Comment 3

[Yura Zenevich [:yzen] (please use "needinfo")]

Comment on attachment 8682195 [details] [diff] [review]
1220860 patch

Review of attachment 8682195 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/jsat/Presentation.jsm
@@ +697,5 @@
>      aPosition, aOldPosition, aReason, aStartOffset, aEndOffset, aIsUserInput) {
>      let context = new PivotContext(
>        aPosition, aOldPosition, aStartOffset, aEndOffset);
> +    if (context.accessible) {
> +      this.displayedAccessibles.set(context.accessible.document.window, context);

This seems to fail, because sometimes context.accessible is null

Comment 4

[Yura Zenevich [:yzen] (please use "needinfo")]

Attachment: 1220860 patch v2

Updated

Comment 5

[Yura Zenevich [:yzen] (please use "needinfo")]

https://hg.mozilla.org/integration/mozilla-inbound/rev/0aea92b111d7

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0aea92b111d7

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/0aea92b111d7

Comment 9

[Yura Zenevich [:yzen] (please use "needinfo")]

For some reason the patch looks missing in v2.5 branch:
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/file/tip/accessible/jsat/AccessFu.jsm#l526

If it didn't stick, is it possible to re-land it on v2.5?