1221377 - After selecting an attachment in Messages it is possible to bring up Keyboard UI

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::System::Window Mgmt, defect)

Description

[John Thomas [:Johnt]]

Attachment: logcat_20151103_1723.txt

Description:
After selecting the attachment paper click from Messages if the user quickly selects the message box afterwards the keyboard will pop up on the attachment type menu. The keyboard has no functionality on this screen. However if the user does input text and then cancels out of this screen the text will appear in the message box afterwards.

Repro Steps:
1) Update a Aries to 20151103140850
2) Select Messages > New Message
3) Select the Paperclip attachment icon
4) Quickly select the Message box afterwards

Actual:
Attachment type (Music, Camera ext..) screen is displayed with Keyboard displayed over it.

Expected:
It is expected that the keyboard UI will not be displayed on the attachment type screen.

Environmental Variables:
Device: Aries 2.6 Kk
BuildID: 20151103140850
Gaia: 06de78d2c61c084956640c480280ba518b2fe29f
Gecko: 59a6ad6a921f4809dfc37d943d765300c65721e5
Gonk: a19052e4389c3ae2d8fc3e7a74a475401baacc56
Version: 45.0a1 (2.6) 
Firmware Version: D5803_23.1.A.1.28_NCB.ftf
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Repro frequency: 5/5
See attached: Logcat & Video

Video: https://youtu.be/0bydiTgjo6A

Comment 1

[John Thomas [:Johnt]]

This issue DOES occur on Flame 2.6 & Flame 2.5.

Environmental Variables:
Device: Flame 2.6 Kk Fullflash (512mb)
BuildID: 20151103030244
Gaia: 06de78d2c61c084956640c480280ba518b2fe29f
Gecko: bb4d614a0b09bcb9738c151dccfcd9b3857a6a7c
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 45.0a1 (2.6) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:45.0) Gecko/45.0 Firefox/45.0

Environmental Variables:
Device: Flame 2.5 Kk Fullflash (512mb)
BuildID: 20151103004501
Gaia: 91cac94948094cfdcd00cba5c6483e27e80cb3b0
Gecko: 4e0955369a51850f2982087145ac5c2df257ffe9
Gonk: 205ac4204bbbb2098a8046444acba551ba5dc75a
Version: 44.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:44.0) Gecko/44.0 Firefox/44.0

----------------------

Environmental Variables:
Device: Flame 2.2 Kk Fullflash (512mb)
BuildID: 20151103032504
Gaia: 885647d92208fb67574ced44004ab2f29d23cb45
Gecko: b8b7f4efaa6e
Gonk: bd9cb3af2a0354577a6903917bc826489050b40d
Version: 37.0 (2.2) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:37.0) Gecko/37.0 Firefox/37.0

Comment 2

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Minor issue that doesn't block usage of the app.  Not nominating to block.  Johan can I get your opinion as well though.

Comment 3

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Let's get a regression window regardless though.

Comment 4

[Johan Lorenzo [:jlorenzo]]

Isabel is the QA contact for Comms. Transferring the NI to her.

Comment 5

[Isabel Rios[:isabel_rios]]

[Tracking Requested - why for this release]:

I got to reproduce it and although is a regression would not block on it. There is a way to hide the keyboard and continue attaching the content. But it will be good to have it fixed, so adding to backlog.
Thanks!

Comment 6

[John Thomas [:Johnt]]

Caused by changes made in Bug 1121316

Gaia Regression Window

Last Working
Environmental Variables:
Device: Flame 2.5
BuildID: 20150504031800
Gaia: 62669d7c45568aa3ebe973d4930b19e609562c0f
Gecko: 89bd1164630b
Version: 40.0a1 (2.5) 
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0

First Broken
Environmental Variables:
Device: Flame 2.5
BuildID: 20150504033600
Gaia: 703b21afffb5d6c8f877d9aeb0d93525e8fd1642
Gecko: f67e3283572e
Version: 40.0a1 (2.5)
Firmware Version: v18D
User Agent: Mozilla/5.0 (Mobile; rv:40.0) Gecko/40.0 Firefox/40.0


Last Working gaia / First Broken gecko - This issue does NOT occur with broken Gecko
Gaia: 62669d7c45568aa3ebe973d4930b19e609562c0f
Gecko: f67e3283572e

Last Working gecko / First Broken gaia - This issue DOES occur with broken Gaia
Gecko: 89bd1164630b
Gaia: 703b21afffb5d6c8f877d9aeb0d93525e8fd1642

Gaia Pushlog:
https://github.com/mozilla-b2g/gaia/compare/62669d7c45568aa3ebe973d4930b19e609562c0f...703b21afffb5d6c8f877d9aeb0d93525e8fd1642

Comment 7

[Jayme Mercado [:JMercado] (Inactive 3/4/2016)]

Alberto this issue seems to have been caused by the changes for bug 1121316.  Can you please take a look?

Comment 8

[GitHub Autolander Bot]

Attachment: [gaia] albertopq:1221377-attachment-sms > mozilla-b2g:master

Comment 9

[Alberto Pastor [:albertopq]]

Comment on attachment 8683778 [details] [review]
[gaia] albertopq:1221377-attachment-sms > mozilla-b2g:master

This works, but I'm not sure about the solution. I was expecting to find a way of the HierarchyManager dealing with the events when the System Dialog is requested to be shown, but didn't succeed.

The problem is that activityrequested/actionmenushowing/... events are triggered before the keyboard had time to start, so line [1] doesn't work.

Etienne, any idea on what's the best way to avoid this race?
Tim, as you are the keyboard master, what do you think?

Thanks guys!

[1]

Comment 10

[Etienne Segonzac (:etienne)]

Comment on attachment 8683778 [details] [review]
[gaia] albertopq:1221377-attachment-sms > mozilla-b2g:master

Given the async-ness of this I don't think we'll find an alternative solution.
We should triple-check that the events are symmetrical enough and that we can't get stuck with preventInput = true, but I think this is the way to go.

Note about testing: the important effect to assert on is that no input window get's .open'ed, not that the preventInput flag is set.

Comment 11

[Alberto Pastor [:albertopq]]

Comment on attachment 8683778 [details] [review]
[gaia] albertopq:1221377-attachment-sms > mozilla-b2g:master

Thanks for the previous feedback!

Comment 12

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 8683778 [details] [review]
[gaia] albertopq:1221377-attachment-sms > mozilla-b2g:master

I agree what Etienne said, it's not possible to know what the remote process will throw at us -- so the current patch looks good. I added a few comment to ensure we always remove the focus when we block the input window from showing up.

It's very sad that we don't have any test suite that properly test and assert these timing stuff. It would be good if we could raise that to people who decide work priorities.

Comment 13

[Etienne Segonzac (:etienne)]

Comment on attachment 8683778 [details] [review]
[gaia] albertopq:1221377-attachment-sms > mozilla-b2g:master

Thanks for the update :)

Comment 14

[Alberto Pastor [:albertopq]]

master: https://github.com/mozilla-b2g/gaia/commit/ad79017bbab3229a02c49cd4cd0c8401e72fc640

Comment 15

[Shally Li（leave from Mozilla）]

This bug has been verified as "pass" on the latest build of Flame KK 2.6 and Aires KK 2.6 by the STR in comment 0.

Actual results: Selecting the Paperclip attachment icon and then quickly selecting the Message box, it can't bring up Keyboard UI, and attachment list shows normally. 
See attachment: verified_Flame_v2.6.3gp
Reproduce rate: 0/10


Device: Flame KK v2.6 512mb (master)(Pass)
Build ID               20151111150236
Gaia Revision          22f8023b112dfae83531b0a075ab9eb9a5444dfa
Gaia Date              2015-11-10 23:35:38
Gecko Revision         https://hg.mozilla.org/mozilla-central/rev/84a7cf29f4f14c9b359db2f7f19c0abd6a8e178e
Gecko Version          45.0a1
Device Name            flame
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.cltbld.20151111.182640
Firmware Date          Wed Nov 11 18:26:52 EST 2015
Firmware Version       v18D v4
Bootloader             L1TC000118D0

Device: Aries KK 2.6 (master)(Pass)
Build ID               20151112014800
Gaia Revision          98f63d4cc530906fa51d839a10469006c257b998
Gaia Date              2015-11-12 02:03:26
Gecko Revision         https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ed7dd831d1969a5a1a8636e63bd93d6aeaf94a
Gecko Version          45.0a1
Device Name            aries
Firmware(Release)      4.4.2
Firmware(Incremental)  eng.worker.20151112.011957
Firmware Date          Thu Nov 12 01:20:05 UTC 2015
Bootloader             s1

Comment 16

[Shally Li（leave from Mozilla）]

Attachment: verifried_Flame_v2.6.3gp