Make New Relic collect request query parameters too

RESOLVED FIXED

Status

Tree Management
Treeherder: Infrastructure
P2
normal
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: emorley, Assigned: emorley)

Tracking

(Blocks: 1 bug)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We currently don't see the query parameters in the referrer for transaction traces etc, so just see eg:

/api/project/mozilla-inbound/jobs/

(From https://rpm.newrelic.com/accounts/677903/applications/4180461/transactions?tw%5Bend%5D=1447182338&tw%5Bstart%5D=1447171538#id=5b225765625472616e73616374696f6e2f46756e6374696f6e2f747265656865726465722e7765626170702e6170692e6a6f62733a4a6f6273566965775365742e637265617465222c22225d&app_trace_id=3fca17-21a6ef70-87d9-11e5-900f-b82a72d22a14 )

This is very useful when trying to debug issues eg bug 1223335.

New Relic has a now deprecated capture_params option, that was turned on in bug 1141036, however:
(a) it doesn't seem to have worked
(b) they've deprecated it in favour of new options

I'll go through the new options and figure out what we want to set:

https://docs.newrelic.com/docs/agents/python-agent/attributes/python-agent-attributes
https://docs.newrelic.com/docs/agents/python-agent/installation-configuration/python-agent-configuration#attributes
https://docs.newrelic.com/docs/agents/python-agent/attributes/enabling-disabling-attributes-python
https://docs.newrelic.com/docs/agents/python-agent/attributes/python-attribute-examples
(Assignee)

Updated

2 years ago
Depends on: 1223497
(Assignee)

Updated

2 years ago
Depends on: 1225634
(Assignee)

Comment 1

2 years ago
Created attachment 8688722 [details] [review]
Make New Relic capture request parameters too
Attachment #8688722 - Flags: review?(wlachance)
Attachment #8688722 - Flags: review?(wlachance) → review+

Comment 2

2 years ago
Commits pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/5457781fe75df372c17bb75e857acd4f4b7d33ff
Bug 1223496 - Update newrelic from v2.56.0.42 to v2.58.1.44

https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-258043
https://docs.newrelic.com/docs/release-notes/agent-release-notes/python-release-notes/python-agent-258144
https://github.com/edmorley/newrelic-python-agent/compare/v2.56.0.42...v2.58.1.44

https://github.com/mozilla/treeherder/commit/cd79f9a96a8e0a0b51722f8df0d7d6f6cfd2c904
Bug 1223496 - Make New Relic capture request parameters too

See:
https://docs.newrelic.com/docs/agents/python-agent/attributes/python-agent-attributes#requestParameters
https://docs.newrelic.com/docs/agents/python-agent/attributes/python-attribute-examples#ex_req_params
(Assignee)

Comment 3

2 years ago
Great this is working on Heroku :-)

On:
https://rpm.newrelic.com/accounts/677903/applications/7385291/traced_errors/70b0cd-b04746cb-8e45-11e5-900f-b82a72d22a14

There's:
parameters	search   	'(try "hg help --keyword share")'
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.