1225634 - Set NEW_RELIC_CONFIG_FILE on stage/prod

Status: RESOLVED FIXED

(Tree Management :: Treeherder: Infrastructure, defect, P2)

Description

[Ed Morley [:emorley]]

Whilst stage/prod have a newrelic config in puppet (which gets saved on the nodes at /etc/newrelic/python.ini), it turns out it's not actually being used at the moment - since that isn't a default New Relic location.

In fact, New Relic doesn't have a default config file location and only uses a one if it is specified via the environment variable NEW_RELIC_CONFIG_FILE.

Since we've had to check in an in-repo config file for Heroku, it makes sense to just use this for stage/prod too.

As such, please can the env variable `NEW_RELIC_CONFIG_FILE` be set to `newrelic.ini` on just stage (for now; we'll need to wait until bug 1182425 is deployed on prod before making the change there).

(The path is relative to the working directory from which newrelic-admin is run, which is always the correct directory, since the bin/run_* scripts change directory before running it.)

Many thanks :-)

Comment 1

[Kendall Libby [:fubar] (he/him)]

Added "export NEW_RELIC_CONFIG_FILE='newrelic.ini'" to staging's profile.sh.erb and treeherder-env.sh.erb in 110694.  Didn't touch prod as it wasn't clear if bug 1182425 was deploy on prod or not.

Comment 2

[Ed Morley [:emorley]]

> Didn't touch prod as it wasn't clear if bug 1182425 was deploy on prod or not.

Sorry yeah that bug is deployed on prod, so we're ok to proceed with prod too. Thanks :-)

Comment 3

[Kendall Libby [:fubar] (he/him)]

rgr, added in 110695 and will roll out in a sec.