Closed
Bug 1223947
Opened 9 years ago
Closed 9 years ago
Cannot trigger Panorama removal warning from Bug 1221500
Categories
(Firefox Graveyard :: Panorama, defect)
Firefox Graveyard
Panorama
Tracking
(firefox44+ verified, firefox45 verified)
VERIFIED
FIXED
Firefox 45
People
(Reporter: sfleiter, Assigned: Gijs)
References
Details
Attachments
(1 file)
40 bytes,
text/x-review-board-request
|
ttaubert
:
review+
ritu
:
approval-mozilla-aurora+
|
Details |
I mentioned in bug 1222786 there should be a warning outside of the Panorama view itself since Users using other interfaces to Panorama like "Tab Groups Helper" do not get informed by that. I was kindly informed about bug 1221500. But I cannot trigger the warning from that bug. Steps to reproduce: - install current firefox nightly or aurora build - start firefox with a new profile - open 2 tab groups with different pages inside - open about:config and set browser.migration.version to 32 - restart firefox with same profile as above What happens: - firefox opens and shows tabs of last active tab group What I expected - besides showing tabs of last active tab groups a warning about Panorama removal should be shown Did I miss sth? Never have seen the warning and I am a daily Firefox Developer Edition user.
Assignee | ||
Comment 1•9 years ago
|
||
Are there errors in the browser console after startup?
Flags: needinfo?(stefan.fleiter)
Assignee | ||
Comment 2•9 years ago
|
||
Gah, nevermind, I can reproduce. This was a result of my following the review feedback and adding a check for firstUseExperienced - but I messed up and called it. It's a getter, I can just read it.
Assignee: nobody → gijskruitbosch+bugs
Flags: needinfo?(stefan.fleiter)
Assignee | ||
Comment 3•9 years ago
|
||
Thanks for catching this so quickly and telling us about it. We'll probably have to re-increment that int so people do actually see this. :-\
Status: NEW → ASSIGNED
Assignee | ||
Updated•9 years ago
|
status-firefox44:
--- → affected
tracking-firefox44:
--- → ?
Assignee | ||
Comment 4•9 years ago
|
||
Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert
Attachment #8686248 -
Flags: review?(ttaubert)
Comment 5•9 years ago
|
||
Comment on attachment 8686248 [details] MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert https://reviewboard.mozilla.org/r/24965/#review22501
Attachment #8686248 -
Flags: review?(ttaubert) → review+
Assignee | ||
Comment 7•9 years ago
|
||
Comment on attachment 8686248 [details] MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert Approval Request Comment [Feature/regressing bug #]: bug 1221500 [User impact if declined]: no warning outside of tab groups that tab groups are going away; [Describe test coverage new/current, TreeHerder]: nope [Risks and why]: very low... the warning outside of tab groups was completely broken, all we're doing now is making it work [String/UUID change made/needed]: no, the strings were already there.
Attachment #8686248 -
Flags: approval-mozilla-aurora?
Reporter | ||
Comment 8•9 years ago
|
||
(In reply to :Gijs Kruitbosch from comment #3) > Thanks for catching this so quickly and telling us about it. > > We'll probably have to re-increment that int so people do actually see this. > :-\ Glad I could help. Thanks for your work!
Comment 9•9 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/a271e4ef0c51
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 45
Stefan, could you please verify that the fix works as expected on the latest Nightly build? Thanks!
Flags: needinfo?(stefan.fleiter)
Flags: qe-verify+
Comment on attachment 8686248 [details] MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert Given that tab groups is going away in 45, we should be showing a warning outside the tab groups. Let's uplift to Aurora44.
Attachment #8686248 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
This is hitting conflicts that I don't feel comfortable fixing myself. Can we get a rebased patch for aurora?
Flags: needinfo?(gijskruitbosch+bugs)
User error on my part, disregard.
Flags: needinfo?(gijskruitbosch+bugs)
Comment 14•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/6f3bd4c434bd
Comment 15•9 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6f3bd4c434bd
status-b2g-v2.5:
--- → fixed
Reporter | ||
Comment 16•9 years ago
|
||
(In reply to Ritu Kothari (:ritu) from comment #10) > Stefan, could you please verify that the fix works as expected on the latest > Nightly build? Thanks! Just saw this message the first time in Aurora aka Firefox Developer Edition after todays update. After that I started up Nightly with another old profile where I had multiple tab groups and saw the message, too. So this seems to be fixed. Thanks a lot!
status-b2g-v2.5:
fixed → ---
Flags: needinfo?(stefan.fleiter)
Comment 17•9 years ago
|
||
Reproduced on Firefox 43.0b4 using the STR from the description. Confirming the fix on 44.0a2 Aurora (2015-11-18) and 45.0a1 Nightly (2015-11-18). The removal warning is properly displayed.
Updated•8 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•