1223947 - Cannot trigger Panorama removal warning from Bug 1221500

Status: VERIFIED FIXED

(Firefox Graveyard :: Panorama, defect)

Description

[Stefan Fleiter (:sfleiter)]

I mentioned in bug 1222786 there should be a warning outside of the Panorama view itself since Users using other interfaces to Panorama like "Tab Groups Helper" do not get informed by that.

I was kindly informed about bug 1221500.
But I cannot trigger the warning from that bug.

Steps to reproduce:
- install current firefox nightly or aurora build
- start firefox with a new profile
- open 2 tab groups with different pages inside
- open about:config and set browser.migration.version to 32
- restart firefox with same profile as above

What happens:
- firefox opens and shows tabs of last active tab group

What I expected
- besides showing tabs of last active tab groups a warning about Panorama removal should be shown

Did I miss sth?
Never have seen the warning and I am a daily Firefox Developer Edition user.

Comment 1

[:Gijs (he/him)]

Are there errors in the browser console after startup?

Comment 2

[:Gijs (he/him)]

Gah, nevermind, I can reproduce. This was a result of my following the review feedback and adding a check for firstUseExperienced - but I messed up and called it. It's a getter, I can just read it.

Comment 3

[:Gijs (he/him)]

Thanks for catching this so quickly and telling us about it.

We'll probably have to re-increment that int so people do actually see this. :-\

Comment 4

[:Gijs (he/him)]

Attachment: MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert

Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert

Comment 5

[Tim Taubert [:ttaubert] (inactive)]

Comment on attachment 8686248 [details]
MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert

https://reviewboard.mozilla.org/r/24965/#review22501

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/fx-team/rev/a271e4ef0c51

Comment 7

[:Gijs (he/him)]

Comment on attachment 8686248 [details]
MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert

Approval Request Comment
[Feature/regressing bug #]: bug 1221500
[User impact if declined]: no warning outside of tab groups that tab groups are going away;
[Describe test coverage new/current, TreeHerder]: nope
[Risks and why]: very low... the warning outside of tab groups was completely broken, all we're doing now is making it work
[String/UUID change made/needed]: no, the strings were already there.

Comment 8

[Stefan Fleiter (:sfleiter)]

(In reply to :Gijs Kruitbosch from comment #3)
> Thanks for catching this so quickly and telling us about it.
> 
> We'll probably have to re-increment that int so people do actually see this.
> :-\

Glad I could help.
Thanks for your work!

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a271e4ef0c51

Comment 10

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Stefan, could you please verify that the fix works as expected on the latest Nightly build? Thanks!

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8686248 [details]
MozReview Request: Bug 1223947 - actually check tab groups' firstUseExperienced, r?ttaubert

Given that tab groups is going away in 45, we should be showing a warning outside the tab groups. Let's uplift to Aurora44.

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

This is hitting conflicts that I don't feel comfortable fixing myself. Can we get a rebased patch for aurora?

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

User error on my part, disregard.

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/6f3bd4c434bd

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-b2g44_v2_5/rev/6f3bd4c434bd

Comment 16

[Stefan Fleiter (:sfleiter)]

(In reply to Ritu Kothari (:ritu) from comment #10)
> Stefan, could you please verify that the fix works as expected on the latest
> Nightly build? Thanks!

Just saw this message the first time in Aurora aka Firefox Developer Edition after todays update.
After that I started up Nightly with another old profile where I had multiple tab groups and saw the message, too.

So this seems to be fixed.

Thanks a lot!

Comment 17

[Cornel Ionce [:noni]]

Reproduced on Firefox 43.0b4 using the STR from the description.

Confirming the fix on 44.0a2 Aurora (2015-11-18) and 45.0a1 Nightly (2015-11-18).
The removal warning is properly displayed.