Closed Bug 1224198 Opened 9 years ago Closed 9 years ago

No visual feedback when clicking 'Sync Now' with no network connectivity

Categories

(Firefox OS Graveyard :: Sync, defect, P3)

Product:
Firefox OS Graveyard
Component:
Sync
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
FxOS-S11 (13Nov)

People

(Reporter: mbdejong, Assigned: ferjm)

References

Details

Attachments

(1 file)

[gaia] ferjm:bug1224198.syncnow.nonetwork > mozilla-b2g:master
46 bytes, text/x-github-pull-request
yzen
: review+
Details | Review 
Disable your WiFi and click 'Sync Now' in B2G. It looks like it was successful and just very fast. It does not tell the user in any way that the sync failed.
Blocks: fxos-sync
Target Milestone: --- → FxOS-S11 (13Nov)
If instead of disabling WiFi you set '123.123.123.123 syncto.dev.mozaws.net' in your /etc/hosts and then click 'Sync Now', the sync attempt takes forever (or at least several minutes).
Ah, in the case of setting /etc/hosts it does correctly show an 'Oops! Something went wrong' alert. Created bug 1224203, bug 1224204, and bug 1224205 about that case. We can keep this bug only about the case where there is no network connectivity at all.
Assignee: nobody → ferjmoreno
Priority: -- → P3
Attachment #8690463 - Flags: review?(yzenevich)
Comment on attachment 8690463 [details] [review]
[gaia] ferjm:bug1224198.syncnow.nonetwork > mozilla-b2g:master

Looks and works well Fernando, would you mind adding a test for this scenario as well? Thanks!
Attachment #8690463 - Flags: review?(yzenevich) → review+
https://github.com/mozilla-b2g/gaia/commit/37250b125e0db6966875d3b37b117f6d9b76cbc0
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: