1224471 - shortcuts_composer.xhtml: Wrong keyboard shortcut "Ctrl+K" for spell check

Status: RESOLVED FIXED

(SeaMonkey :: Help Documentation, defect)

Description

[Rainer Bielefeld]

Steps how to reproduce with  SeaMonkey German (en-US Language Pack) 2.39 final Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0 from official download area)  Gecko/20100101  Firefox/42.0  Build 20151103191810  (Classic Theme) on German WIN7 64bit:

1. Launch E-Mail client
2. Click 'Compose'
3. type few text words
4. Menu 'Help  → Search for "Composer Shortcuts"'
   » Find "Check Spelling: Ctrl+K"
5. Switch to Composer Window <ctrl+k>
   Expected: Spell check starts, Spell Check dialog appears
   Bug: Nothing happens

Additional info:
a) Same problem in HTML-Web-Page-Composer
b) Menu 'Edit → Check spelling ...' shows correct shortcut <ctrl+shift+p>
c)  REPRODUCIBLE with  German SeaMonkey 2.41a1  (X11; Linux x86_64; 
    rv:44.0)  Gecko/20100101 Firefox/44.0 Build 20151029003002  
    (Classic Theme) on VirtualBox Ubuntu 14
d) I can't tell what the shortcut is on Mac
e) Might have started with Bug 110517 - ctrl-k doesn't work in mail,
   not a new problem in Help

Comment 1

[Rainer Bielefeld]

f) No DUPs found with <https://bugzilla.mozilla.org/buglist.cgi?cmdtype=dorem&remaction=run&namedcmd=DUPs1224471&sharer_id=41036>

Comment 2

[Stefan [:stefanh]]

The mac shortcut is Cmd+Shift+P. What's worse is that Cmd+Shift+P also is used for opening a private window... sigh.

Comment 3

[Stefan [:stefanh]]

The mac shortcut is Cmd+Shift+P.

Comment 4

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #2)
> The mac shortcut is Cmd+Shift+P. What's worse is that Cmd+Shift+P also is
> used for opening a private window... sigh.

Bah, I mid-aired with myself. The private window shortcut is actually Cmd+Shift+B, but in my sv-SE version it's still Cmd+Shift+P (it was changed in en-US back in 2013).

Comment 5

[Ian Neal]

It's Ctrl+Shift+P on Linux, what is it on Windows? (Should be shown in a compose window under Edit menu, Check Spelling...)
Should a very simple change to help. Might be worth doing the help changes for bug 1293048 at the same time.

Comment 6

[Rainer Bielefeld]

Official en-US SeaMonkey 2.48a1  (NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 Build 20160804000913  (Default Classic Theme) on German WIN7 64bit:
<ctrl+shift+p> for new private browser window from browser (as stated in Help
               and Menu 'File')
<ctrl+shift+b> for new private browser window from Composer, I think this 
               difference is unnecessary and unintuitive
<ctrl+shift+p> for SPELLCHECK in Composer and Email Composer
               (as stated in Menu 'Edit')

f) Thunderbird 50.0a1 (2016-07-09) WIN7 also uses <ctrl+shift+p> for 
   Spell Check as stated on <https://support.mozilla.org/en-US/kb/keyboard-shortcuts#w_writing-messages>
g) FF 51.0a1 (2016-08-04) WIN7 also uses <ctrl+shift+p> for new 
   private browser window from browser

Comment 7

[Ian Neal]

At the moment there's a mix between B and P being used across locales. For en-US it seems to be B in all windows, and, as SM uses the same entity newPrivateWindowCmd.key in all windows, I would not expect it to vary within a locale. Could you double check?

Comment 8

[Richard Marti (:Paenglab)]

For info, bug 1293048 changes accel + L for the Link dialog to accel+ K to use the same shortcut like word processors use.

Comment 9

[Rainer Bielefeld]

(In reply to Ian Neal (Away until 7th Aug) from comment #7)
> Could you double check?

I started investigation, but it's toilsome, will take a while

Comment 10

[Ton [:Tonnes]]

Wouldn’t it suffice to just change the doc’s listing to Ctrl+Shift+P/Cmd+Shift+P/Ctrl+Shift+P?
Also see bug 1294153 comment 6.

Comment 11

[Rainer Bielefeld]

(In reply to Ton from comment #10)
> Wouldn’t it suffice 

Yes, of course. I do not expect that en-US shortcuts will change.

Concerning localization inconsistencies Ian Neal expects I will create a complete listing today in the evening. But that is more or less independent form this Help issue here.

Comment 12

[Rainer Bielefeld]

Attachment: comparison menu-shortcut hint and actual behavior

Actual menu texts and actual behavior of some localizations (not all loalizations tested yet):

Tested: works fine
-------------------
English (US), Galician, German, Italian, Slovak, Spanish (Spain), Swedish, 

Tested: Buggy
-------------
Belarusian, Czech, French, Hungarian, Lithuanian,Norwegian (Bokmål), Polish, 
Dutch: Bug 1294153

Not yet tested
--------------
Catalan, Chinese (Simplified), Chinese (Traditional), English (British), Japanese, Finnish, Portuguese (Portugal), Russian, Spanish (Argentina), Turkish, Ukrainian, 

--
All this only for information, we will have to create localization bug(s) for "Tested: Buggy"  after confirmation that en-US behavior will stay.

Comment 13

[Rainer Bielefeld]

Attachment: comparison menu-shortcut hint and actual behavior

(better document version)

Comment 14

[Ton [:Tonnes]]

Attachment: Change shortcuts in doc

Comment 15

[Ian Neal]

Comment on attachment 8782014 [details] [diff] [review]
Change shortcuts in doc

B is used for New Private Window
P is used for Check Spelling
So this patch needs Ctrl+Shift+P/Cmd+Shift+P/Ctrl+Shift+P

Comment 16

[Ton [:Tonnes]]

Attachment: Change shortcuts in doc v2

Must have been the heat. ;)

Comment 17

[Ian Neal]

Comment on attachment 8785954 [details] [diff] [review]
Change shortcuts in doc v2

r/a=me

Comment 18

[rsx11m]

http://hg.mozilla.org/comm-central/rev/bcb5f54ebc2a