Closed
Bug 1224471
Opened 9 years ago
Closed 8 years ago
shortcuts_composer.xhtml: Wrong keyboard shortcut "Ctrl+K" for spell check
Categories
(SeaMonkey :: Help Documentation, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
seamonkey2.48
People
(Reporter: RainerBielefeldNG, Assigned: Tonnes)
References
(Blocks 1 open bug)
Details
User Story
Affected Localizations ====================== With en-US Help: ---------------- - nl, see also Bug 1294153 for UI inconsistence With localized Help: -------------------- -
Attachments
(2 files, 2 obsolete files)
68.00 KB,
application/pdf
|
Details | |
990 bytes,
patch
|
iannbugzilla
:
review+
|
Details | Diff | Splinter Review |
Steps how to reproduce with SeaMonkey German (en-US Language Pack) 2.39 final Mozilla/5.0 (Windows NT 6.1; WOW64; rv:42.0 from official download area) Gecko/20100101 Firefox/42.0 Build 20151103191810 (Classic Theme) on German WIN7 64bit:
1. Launch E-Mail client
2. Click 'Compose'
3. type few text words
4. Menu 'Help → Search for "Composer Shortcuts"'
» Find "Check Spelling: Ctrl+K"
5. Switch to Composer Window <ctrl+k>
Expected: Spell check starts, Spell Check dialog appears
Bug: Nothing happens
Additional info:
a) Same problem in HTML-Web-Page-Composer
b) Menu 'Edit → Check spelling ...' shows correct shortcut <ctrl+shift+p>
c) REPRODUCIBLE with German SeaMonkey 2.41a1 (X11; Linux x86_64;
rv:44.0) Gecko/20100101 Firefox/44.0 Build 20151029003002
(Classic Theme) on VirtualBox Ubuntu 14
d) I can't tell what the shortcut is on Mac
e) Might have started with Bug 110517 - ctrl-k doesn't work in mail,
not a new problem in Help
Reporter | ||
Comment 1•9 years ago
|
||
Comment 2•9 years ago
|
||
The mac shortcut is Cmd+Shift+P. What's worse is that Cmd+Shift+P also is used for opening a private window... sigh.
Comment 3•9 years ago
|
||
The mac shortcut is Cmd+Shift+P.
Comment 4•9 years ago
|
||
(In reply to Stefan [:stefanh] from comment #2)
> The mac shortcut is Cmd+Shift+P. What's worse is that Cmd+Shift+P also is
> used for opening a private window... sigh.
Bah, I mid-aired with myself. The private window shortcut is actually Cmd+Shift+B, but in my sv-SE version it's still Cmd+Shift+P (it was changed in en-US back in 2013).
It's Ctrl+Shift+P on Linux, what is it on Windows? (Should be shown in a compose window under Edit menu, Check Spelling...)
Should a very simple change to help. Might be worth doing the help changes for bug 1293048 at the same time.
Depends on: 1293048
Flags: needinfo?(RainerBielefeldNG)
Reporter | ||
Comment 6•8 years ago
|
||
Official en-US SeaMonkey 2.48a1 (NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 Build 20160804000913 (Default Classic Theme) on German WIN7 64bit:
<ctrl+shift+p> for new private browser window from browser (as stated in Help
and Menu 'File')
<ctrl+shift+b> for new private browser window from Composer, I think this
difference is unnecessary and unintuitive
<ctrl+shift+p> for SPELLCHECK in Composer and Email Composer
(as stated in Menu 'Edit')
f) Thunderbird 50.0a1 (2016-07-09) WIN7 also uses <ctrl+shift+p> for
Spell Check as stated on <https://support.mozilla.org/en-US/kb/keyboard-shortcuts#w_writing-messages>
g) FF 51.0a1 (2016-08-04) WIN7 also uses <ctrl+shift+p> for new
private browser window from browser
Flags: needinfo?(RainerBielefeldNG)
Summary: Wrong keyboard shortcut "Ctrl+K" for spell check → shortcuts_composer.xhtml: Wrong keyboard shortcut "Ctrl+K" for spell check
Reporter | ||
Updated•8 years ago
|
Blocks: HelpCleanup2016
At the moment there's a mix between B and P being used across locales. For en-US it seems to be B in all windows, and, as SM uses the same entity newPrivateWindowCmd.key in all windows, I would not expect it to vary within a locale. Could you double check?
Flags: needinfo?(RainerBielefeldNG)
Comment 8•8 years ago
|
||
For info, bug 1293048 changes accel + L for the Link dialog to accel+ K to use the same shortcut like word processors use.
Reporter | ||
Comment 9•8 years ago
|
||
(In reply to Ian Neal (Away until 7th Aug) from comment #7)
> Could you double check?
I started investigation, but it's toilsome, will take a while
User Story: (updated)
Flags: needinfo?(RainerBielefeldNG)
Assignee | ||
Comment 10•8 years ago
|
||
Wouldn’t it suffice to just change the doc’s listing to Ctrl+Shift+P/Cmd+Shift+P/Ctrl+Shift+P?
Also see bug 1294153 comment 6.
Reporter | ||
Comment 11•8 years ago
|
||
(In reply to Ton from comment #10)
> Wouldn’t it suffice
Yes, of course. I do not expect that en-US shortcuts will change.
Concerning localization inconsistencies Ian Neal expects I will create a complete listing today in the evening. But that is more or less independent form this Help issue here.
Reporter | ||
Comment 12•8 years ago
|
||
Actual menu texts and actual behavior of some localizations (not all loalizations tested yet):
Tested: works fine
-------------------
English (US), Galician, German, Italian, Slovak, Spanish (Spain), Swedish,
Tested: Buggy
-------------
Belarusian, Czech, French, Hungarian, Lithuanian,Norwegian (Bokmål), Polish,
Dutch: Bug 1294153
Not yet tested
--------------
Catalan, Chinese (Simplified), Chinese (Traditional), English (British), Japanese, Finnish, Portuguese (Portugal), Russian, Spanish (Argentina), Turkish, Ukrainian,
--
All this only for information, we will have to create localization bug(s) for "Tested: Buggy" after confirmation that en-US behavior will stay.
Reporter | ||
Comment 13•8 years ago
|
||
(better document version)
Attachment #8781840 -
Attachment is obsolete: true
Assignee | ||
Comment 14•8 years ago
|
||
Attachment #8782014 -
Flags: review?(iann_bugzilla)
Updated•8 years ago
|
Assignee: nobody → tonnes.mb
Status: NEW → ASSIGNED
Comment 15•8 years ago
|
||
Comment on attachment 8782014 [details] [diff] [review]
Change shortcuts in doc
B is used for New Private Window
P is used for Check Spelling
So this patch needs Ctrl+Shift+P/Cmd+Shift+P/Ctrl+Shift+P
Attachment #8782014 -
Flags: review?(iann_bugzilla) → review-
Assignee | ||
Comment 16•8 years ago
|
||
Must have been the heat. ;)
Attachment #8782014 -
Attachment is obsolete: true
Attachment #8785954 -
Flags: review?(iann_bugzilla)
Comment 17•8 years ago
|
||
Comment on attachment 8785954 [details] [diff] [review]
Change shortcuts in doc v2
r/a=me
Attachment #8785954 -
Flags: review?(iann_bugzilla) → review+
Keywords: checkin-needed
Comment 18•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.48
You need to log in
before you can comment on or make changes to this bug.
Description
•