1294153 - SeaMonkey UI: Browser, Mail-Composer, HTML-Composer: fix Private Window keyboard shortcut

Status: RESOLVED FIXED

(Mozilla Localizations :: nl / Dutch, defect)

Description

[Rainer Bielefeld]

Steps how to reproducewith official en-US SeaMonkey 2.48a1  (NT 6.1; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 Build 20160804000913  (Default Classic Theme) on German WIN7 64bit and Language pack from <https://l10n.mozilla-community.org/~akalla/unofficial/seamonkey/nightly/latest-comm-central-windows32/>:

1. In Browser, Mail-Composer, HTML-Composer try Menu ˋEditˊ 
   » Menu Item for spell check works correctly
     Bug: mentioned shortcut is <ctrl+shift+p> what will open a new
          private browser window
2. Try <ctrl+shift+p> for Browser, Mail-Composer, HTML-Composer:
   » will open a new private browser window as stated above

a) I did not find the correct shortcut for spell check with UI in
   NL language
b) I think with a fix for this one here we will have to wait for
   "Bug 1224471 Wrong keyboard shortcut "Ctrl+K" for spell check" 
   because it might be that there will be some unification for UI    
   as a result.
c) If NL will not follow en-US UI NL-Help will have to be adapted.

Comment 1

[Rainer Bielefeld]

.

Comment 2

[Ton [:Tonnes]]

Thank you, but I doubt if bugs like these will be needed for our locale. Some things might be broken right now but as with Help files, we just follow what en-US uses - in this case, shortcut keys that should not be localized. I’m afraid it will also cost you energy whereas such bugs may be overlooked or ignored.

See https://transvision.mozfr.org/?recherche=checkSpellingCmd2.key&repo=aurora&sourcelocale=en-US&locale=nl&search_type=entities - Click the green "l10n" button to view other locales for any of them - locales that did localize them will stand out, but keep in mind they may have done so intentionally.

Apparently the real issue is that ctrl+shift+p is also used for opening a Private window, as mentioned in bug 1224471 comment 2. Since that was introduced later, a first suggestion would be to have that one changed, while on the other hand, more people may be familiar with it for private windows meanwhile, and I don’t think FF is going to change this for SM. I’m not entirely sure if it can be changed for SM only. If the (other) issue is that ctrl+k was intended to be used by SM only, that may be hard because of the shared editor file, but I don’t think it ever was. But all this is about bug 1224471.

Anyway, anything not working or changing for our locale will be fixed as soon as en-US gets fixed. As for this bug’s title, I think there is nothing "wrongly stated". To reply to your a/b/c:

a) The shortcut for nl is curently similar to the one for en-US
b) Yes, if en-US will be fixed by bug 1224471, it will be fixed for nl and others and we/others will notice on the dashboard
c) Every locale needs to follow, since these are shortcuts, not access keys.

Comment 3

[Onno Ekker [:nONoNonO UTC+1]]

Looks like the shortcut key changed in 2009 from Ctrl+K to Ctrl+Shift+P, but the Help files weren't updated: https://hg.mozilla.org/releases/comm-aurora/rev/3e31d68c0edb
Now I guess that first a new key combination should be established to activate the spelling checker and then the help files should be updated accordingly.

Comment 4

[Ton [:Tonnes]]

Private Browsing in SeaMonkey should use the B command key after bug 891081 changed it from P to B without entity change (…), so there would be no issue with spell checking. The P for Dutch was used in https://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/diff/5a6bb17c7977/suite/chrome/common/utilityOverlay.dtd#l26 from the beginning following bug 837510 (including a non-existent access key), bug 891081 was obviously never noticed.

See https://transvision.mozfr.org/string/?entity=suite/chrome/common/utilityOverlay.dtd:newPrivateWindowCmd.key&repo=aurora for locales still using P (currently 14).

Should we mark this WFM or Invalid?

Comment 5

[Rainer Bielefeld]

@Onno Ekker,  Ton:
Your comments havenn't to do anything with the reported bug.
We don't talk about Help here, but about shortcuts shown in men 'Edit' pulldown.

But Indeed, I also made a mistake.
In Browser, the bug is that menu "File" (Bestand) tells that <cntrl+shift+p> would open a new private window, but the actual shortcut is <cntrl+shift+b>

Comment 6

[Ton [:Tonnes]]

Rainer,

I know and replied here because this appears to be a bug for nl, but it’s merely a reply to bug 1224471 because of the original cause. In that bug, you report the Ctrl+K key not working, and then you rolled into / created another bug (for other than en-US or your own locale) telling Ctrl+Shift+P is wrongly stated for the spell check whereas this does not appear to be true. Therefore the title/purpose of this bug isn’t true nor clear either, and it’s "causing some noise" as some devs would put it.

Instead, the only thing that apparently needs to be corrected is the spell check shortcut listing in shortcuts_composer.xhtml (changed by bug 461317 like Onno wrote), and it’s unclear to me what more should be investigated as well as toilsome there. That Help file change (to Ctrl+Shift+P/Cmd+Shift+P/Ctrl+Shift+P for Win/Mac/Linux) should be a matter of minutes, and I just think you may save yourself and others some further time and trouble.

We will take care of the P->B change for new private windows, and nl Help files will be synced with en-US anyway. (For the record, searchMailcmd.key is another key that may need to be corrected for a number of locales because of S/F mismatches - unless F was used intentionally to match TB, though not advised.)

So either we should mark this bug as invalid, or rename it to be valid for the private window shortcut only, unless I overlooked something.

Comment 7

[Rainer Bielefeld]

Attachment: comparison of locales' behavior

d) this one is a nl localization issue, not a general localization issue.
   In German de-DE localization shortcuts shown in menus are correct.
   But I expect that most locale will have the same problem, I will check 
   other locale today in the evening
e) this one is a nl localization issue, not a general localization issue.
   German de-DE localization shortcuts are the same as in en-US. Of course
   nl localization team can decide to use different shortcuts, but I doubt that 
   they want to do that.
   I expect that most locale will have the same problem, I will check 
   other locale today in the evening
f) I expect that en-US shortcuts for Private Window and Spell check will not 
   change.

Comment 8

[Rainer Bielefeld]

g) and of course menu hints for shortcuts may not be wrong

Comment 9

[Rainer Bielefeld]

Attachment: comparison of locales' behavior

(better document version)

Comment 10

[Ton [:Tonnes]]

(In reply to Rainer Bielefeld from comment #7)
> d/e) this one is a nl localization issue, not a general localization issue.
No it is not, it’s a general localization issue originated from a lacking identifier change in bug 891081 despite the late-change keyword and newsgroup post. As I wrote earlier, no locale should decide to use other shortcuts.

> f) I expect that en-US shortcuts for Private Window and Spell check will not change.
Right, therefore only the Help file should change to include the real shortcut.

This should be fixed by http://hg.mozilla.org/releases/l10n/mozilla-aurora/nl/rev/a8f2fb048f55 (including Search Messages shortcut).

Comment 11

[Rainer Bielefeld]

(In reply to Ton from comment #10)
Thank you

Comment 12

[Ton [:Tonnes]]

Thank you for reporting. ;)