1225431 - [TV][2.5][browser] Revise l10n string from 'Disconnect' to 'Sign Out' in setting page

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::Browser, defect, P2)

Description

[Dan Huang[:danhuang]]

The disconnect button's l10n string in setting page should be revise to 'Sign out'.

Comment 1

[Dan Huang[:danhuang]]

copy review: 
https://docs.google.com/spreadsheets/d/1Xb_R00AoFXR9UY3CGln9yygm0GyFqy0zaHEWbjSfKpw/edit#gid=0

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] danhuang1202:1225431_revise_l10n_from_disconnect_to_signout > mozilla-b2g:master

Comment 3

[Dan Huang[:danhuang]]

Comment on attachment 8689917 [details] [review]
[gaia] danhuang1202:1225431_revise_l10n_from_disconnect_to_signout > mozilla-b2g:master

Hi Sean, please help me review! This patch revise i10n string from fxsync-disconnect to fxsync-sign-out and fxsync-confirm-disconnect to fxsync-confirm-sign-out. Thanks.

Comment 4

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8689917 [details] [review]
[gaia] danhuang1202:1225431_revise_l10n_from_disconnect_to_signout > mozilla-b2g:master

LGTM!

Comment 5

[Dan Huang[:danhuang]]

Thanks for the review.
Merge in master: https://github.com/mozilla-b2g/gaia/commit/96b8112a2ee931eb217a763f7f95607a045dd835.

Comment 6

[Dan Huang[:danhuang]]

Comment on attachment 8689917 [details] [review]
[gaia] danhuang1202:1225431_revise_l10n_from_disconnect_to_signout > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Bug 1194108 
[User impact] if declined: align to the result of copy right review
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=7c18e69d04999b07209434b6468eb8be3034a465
[Risk to taking this patch] (and alternatives if risky): None
[String changes made]: Yes

Comment 7

[Josh Cheng [:josh]]

Comment on attachment 8689917 [details] [review]
[gaia] danhuang1202:1225431_revise_l10n_from_disconnect_to_signout > mozilla-b2g:master

Approve as this is for TV 2.5 feature

Comment 8

[Carsten Book [:Tomcat]]

Hi, this cause problems during uplift 

Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 7c18e69d04999b07209434b6468eb8be3034a465
error: could not apply 7c18e69... Bug 1225431 - revice l10 String to fxsync-sign-out and fxsync-confirm-sign-out. r=seanlee
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add <paths>' or 'git rm <paths>'
hint: and commit the result with 'git commit'

could you take a look and provide a 2.5 PR request thanks!

Comment 9

[Dan Huang[:danhuang]]

This patch should be cherry-pick after bug 1218314 and bug 1217385. If there still have conflicts, feel free to ni me.

Comment 11

[Carsten Book [:Tomcat]]

for 2.5 https://github.com/mozilla-b2g/gaia/commit/e333b79bf34163e78fb2f5ee5d748c3f17ca23f6