1218314 - Re-skin and animate UI components in the Firefox Account sign in flow

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect, P1)

Comment 1

[yifan [:yifan][:yliao]]

[Blocking Requested - why for this release]:

Comment 2

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

Comment 3

[Fernando Jiménez Moreno [:ferjm]]

Comment on attachment 8680677 [details] [review]
[gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

LGTM.

However, I'd like someone from UX to do an UI review before landing if possible.

Also, there's a functional issue with the refresh auth screen: the escape key doesn't work. And I see this on the logcat when entering in the auth screen.

JavaScript error: app://smart-system.gaiamobile.org/fxa/js/fxam_navigation.js, line 40: SyntaxError: An invalid or illegal string was specified

Comment 4

[Dan Huang[:danhuang]]

Comment on attachment 8680677 [details] [review]
[gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

Thanks for you great effort. There just few nits needs to fix.

Comment 5

[Dan Huang[:danhuang]]

Comment on attachment 8680677 [details] [review]
[gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

update review tag!

Comment 6

[yifan [:yifan][:yliao]]

Comment on attachment 8680677 [details] [review]
[gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

Hi Peko, could you please help to review the UI changes? I could setup the changes for you when you're available. Thanks!

Comment 7

[Peko Chen [:pekochen]]

(In reply to yifan [:yifan][:yliao] from comment #6)
> Comment on attachment 8680677 [details] [review]
> [gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master
> 
> Hi Peko, could you please help to review the UI changes? I could setup the
> changes for you when you're available. Thanks!

Hi 
new design has updated already.
Please check the image on google drive.

Comment 8

[yifan [:yifan][:yliao]]

Thanks! Let's correct UI issues in follow up bug if any.

https://github.com/mozilla-b2g/gaia/commit/95047b652729496ec074acd85b0f1710dc28743e

Comment 10

[yifan [:yifan][:yliao]]

Comment on attachment 8680677 [details] [review]
[gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: Not by design visual and missing key interactions.
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=123a30e7e9e295a8457d4f0c7a7030c8f94ffbe6
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 11

[Mahendra Potharaju [:mahe]]

Comment on attachment 8680677 [details] [review]
[gaia] begeeben:1218314_reskin_and_animate > mozilla-b2g:master

Approved for 2.5. 

Thanks

Comment 12

[Carsten Book [:Tomcat]]

Hi, this cause conflicts when uplifting to 2.5 

Tomcats-MacBook-Pro-2:gaia Tomcat$ git cherry-pick 123a30e7e9e295a8457d4f0c7a7030c8f94ffbe6
error: The following untracked working tree files would be overwritten by merge:
	tv_apps/browser/style/components.css

could you take a look and maybe provide a 2.5 PR request thanks!

Comment 13

[yifan [:yifan][:yliao]]

This patch should be uplifted before bug 1222332 because that bug depends on this one. If there is still problems please feel free to ni me again.

Comment 14

[Carsten Book [:Tomcat]]

landed on 2.5 as https://github.com/mozilla-b2g/gaia/commit/177503df7cb4903e272ea33b6fbd6101e8d02c4c