1227013 - Failed to leave the error page by pressing ESC (back button on a remote) in the sign in flow

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::TV::System, defect, P3)

Description

[yifan [:yifan][:yliao]]

Pressing ESC should close the error page.

Comment 1

[Evelyn Hung]

Which error page are you referring to? Could you provide a STR? Thanks.

Comment 2

[Evelyn Hung]

[Blocking Requested - why for this release]:

Comment 3

[yifan [:yifan][:yliao]]

The bug refers to all the error pages displayed by the tv_apps/smart-system/fxa/elements/fxa-error-overlay.html . All kinds of errors regarding Firefox Account sign in are included.

Comment 4

[yifan [:yifan][:yliao]]

For TV users, they can still leave the error page by pressing the OK button. This bug might happen to someone who wants to press the back key on a remote to leave the error pages.

Comment 5

[Evelyn Hung]

(In reply to yifan [:yifan][:yliao] from comment #4)
> For TV users, they can still leave the error page by pressing the OK button.
> This bug might happen to someone who wants to press the back key on a remote
> to leave the error pages.

From your description, I don't think it's a blocker because UX design wants user to know the information and click 'ok' to confirm. It's a nice-have to provide another way to dismiss.

Not a blocker but if you have patch ready, request approval for uplift 2.5.

Comment 6

[GitHub Autolander Bot]

Attachment: [gaia] begeeben:1227013_failed_to_leave > mozilla-b2g:master

Comment 7

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8692791 [details] [review]
[gaia] begeeben:1227013_failed_to_leave > mozilla-b2g:master

LGTM. Thanks!

Comment 8

[yifan [:yifan][:yliao]]

Merged into master:
https://github.com/mozilla-b2g/gaia/commit/a79edcb76acca8eae75fba3cd54a24d6361ee4ea

Comment 9

[yifan [:yifan][:yliao]]

Comment on attachment 8692791 [details] [review]
[gaia] begeeben:1227013_failed_to_leave > mozilla-b2g:master

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): 1194108
[User impact] if declined: Can't leave a error dialog in the Firefox Account sign in flow with the back key on a remote
[Testing completed]: https://treeherder.mozilla.org/#/jobs?repo=gaia&revision=f8cc5373a66d4ad6a1ce72e59bc73441d3e1dbce
[Risk to taking this patch] (and alternatives if risky): none
[String changes made]: none

Comment 10

[yifan [:yifan][:yliao]]

[Blocking Requested - why for this release]: Can't leave a error dialog in the Firefox Account sign in flow with the back key on a remote.

Comment 11

[Josh Cheng [:josh]]

Comment on attachment 8692791 [details] [review]
[gaia] begeeben:1227013_failed_to_leave > mozilla-b2g:master

Approve for TV 2.5

Comment 12

[Carsten Book [:Tomcat]]

https://github.com/mozilla-b2g/gaia/commit/b1fe3b569abf95d7f67b5b7901d43e0179f600c9 for 2.5

Comment 13

[Cynthia Tang [:cynthiatang]]

Verified on

=======  Passed in Master branch  ==================== 
commit ff662257263e9d71f8202d9d61a1b2035944e346
Merge: af7fe55 ae5cbee
Author: Johan Lorenzo <[e-mail]>
Date:   Fri Dec 4 12:26:37 2015 +0100

=======  Passed in v2.5 branch ==================== 
Commit 2d54c29f429bed790b5d8284633812dc2b782518
Author: Fischer.json <[e-mail]>
Date:   Mon Nov 30 15:06:13 2015 +0800