1227031 - mod_perl workers are being terminated after 0 seconds

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: General, defect)

Description

[:glob ✱]

all mod_perl workers are being terminated after 0 seconds
> unshared=467520 requests=2 lifetime=0s size=472192 share=4672

this is because production's localconfig has:
> $apache_size_limit = 250000;
this value should be 700000.

this would be causing a performance hit on all bmo requests.

Comment 1

[:glob ✱]

also the elsif block from mod_perl.pl should be removed:

> my $apache_size_limit = 250_000;
> if (Bugzilla->localconfig->{apache_size_limit}) {
>     $apache_size_limit = Bugzilla->localconfig->{apache_size_limit};
> }
> elsif (Bugzilla->params->{'urlbase'} eq 'https://bugzilla.mozilla.org/') {
>     $apache_size_limit = 700_000;
> }

checksetup always adds apache_size_limit to localconfig so this condition is never hit, and it gives the impression that the correct value of 700000 will be used in production.

Comment 2

[Dylan Hardison [:dylan] (he/him)]

Attachment: 1227031_1.patch

Comment 3

[:glob ✱]

Comment on attachment 8690812 [details] [diff] [review]
1227031_1.patch

Review of attachment 8690812 [details] [diff] [review]:
-----------------------------------------------------------------

r=glob

you'll also have to ask fubar to update puppet/whatever to set the right value in the localconfig file on scl3-prod.

Comment 4

[Dylan Hardison [:dylan] (he/him)]

To ssh://[e-mail]/webtools/bmo/bugzilla.git
   14bb07a..fe886c6  master -> master