1227918 - An exception which cause Marionette to quit does not print any traceback to the console

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This might be similar what Syd has been seen yesterday with invalid command line options for Firefox media tests. In this case it happens for our firefox update tests. We register our own Argument class and have a verify_usage_handler() setup. When this handler raises an exception, Marionette simply quits.

I have seen that while working on the following PR:

https://github.com/mozilla/firefox-ui-tests/pull/291/files#diff-b44fc26c8d5be641ada9dcacd02170e9R54

Example command line:

firefox-ui-update --binary /mozilla/bin/nightly/firefox --update-direct-only --update-fallback-only

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+2]]

So I see the same behavior now when I hit ctrl-c while the tests are running. No traceback is printed to the console. We just die silently.

This makes it very hard to diagnose problems and should be fixed ASAP.

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Here's the culprit https://hg.mozilla.org/mozilla-central/rev/c308db03b242#l1.37

Comment 3

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Attachment: MozReview Request: Bug 1227918 - Log exception in harness class setup; r?automatedtester

Bug 1227918 - Log exception in harness class setup; r?automatedtester

Comment 4

[David Burns :automatedtester]

Comment on attachment 8692750 [details]
MozReview Request: Bug 1227918 - Log exception in harness class setup; r?automatedtester

https://reviewboard.mozilla.org/r/26319/#review23773

Comment 5

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b0e2dd7b8268

Comment 6

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/679df0066972

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/679df0066972

Comment 8

[Syd Polk :sydpolk]

What version of which piece of marionette do we need to get this bug?

Comment 9

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

marionette-client 2.0.0 had the bug; it's fixed in marionette-client 2.1.0. We added workarounds in ui-tests and media-tests while waiting for 2.1.0 to be released.