Closed Bug 1227918 Opened 5 years ago Closed 5 years ago
An exception which cause Marionette to quit does not print any traceback to the console
40 bytes, text/x-review-board-request
This might be similar what Syd has been seen yesterday with invalid command line options for Firefox media tests. In this case it happens for our firefox update tests. We register our own Argument class and have a verify_usage_handler() setup. When this handler raises an exception, Marionette simply quits. I have seen that while working on the following PR: https://github.com/mozilla/firefox-ui-tests/pull/291/files#diff-b44fc26c8d5be641ada9dcacd02170e9R54 Example command line: firefox-ui-update --binary /mozilla/bin/nightly/firefox --update-direct-only --update-fallback-only
So I see the same behavior now when I hit ctrl-c while the tests are running. No traceback is printed to the console. We just die silently. This makes it very hard to diagnose problems and should be fixed ASAP.
Severity: normal → major
Summary: Marionette silently closes if verify_usage_handler() raises an exception → An exception which cause Marionette to quit does not print any traceback to the console
5 years ago
Assignee: nobody → mjzffr
Here's the culprit https://hg.mozilla.org/mozilla-central/rev/c308db03b242#l1.37
Bug 1227918 - Log exception in harness class setup; r?automatedtester
Attachment #8692750 - Flags: review?(dburns)
Comment on attachment 8692750 [details] MozReview Request: Bug 1227918 - Log exception in harness class setup; r?automatedtester https://reviewboard.mozilla.org/r/26319/#review23773
Attachment #8692750 - Flags: review?(dburns) → review+
What version of which piece of marionette do we need to get this bug?
marionette-client 2.0.0 had the bug; it's fixed in marionette-client 2.1.0. We added workarounds in ui-tests and media-tests while waiting for 2.1.0 to be released.
Depends on: 1284502
You need to log in before you can comment on or make changes to this bug.