Closed
Bug 1228652
Opened 5 years ago
Closed 5 years ago
Intermittent e10s browser_privatebrowsing_nonbrowser.js | A promise chain failed to handle a rejection: - at resource:///modules/sessionstore/SessionStore.jsm:3840 - TypeError: this._windows[aWindow.__SSi] is undefined
Categories
(Firefox :: Session Restore, defect)
Firefox
Session Restore
Tracking
()
RESOLVED
FIXED
Firefox 47
People
(Reporter: philor, Assigned: mconley)
References
(Blocks 1 open bug)
Details
(Keywords: intermittent-failure)
Attachments
(1 file)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Reporter | ||
Updated•5 years ago
|
Summary: Intermittent browser_privatebrowsing_nonbrowser.js | A promise chain failed to handle a rejection: - at resource:///modules/sessionstore/SessionStore.jsm:3840 - TypeError: this._windows[aWindow.__SSi] is undefined → Intermittent e10s browser_privatebrowsing_nonbrowser.js | A promise chain failed to handle a rejection: - at resource:///modules/sessionstore/SessionStore.jsm:3840 - TypeError: this._windows[aWindow.__SSi] is undefined
Updated•5 years ago
|
Blocks: e10s-tests
tracking-e10s:
--- → +
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•5 years ago
|
status-firefox45:
--- → affected
status-firefox46:
--- → affected
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 11•5 years ago
|
||
e10s-only failure that looks related to SessionStore. Any thoughts, Mike? :)
Flags: needinfo?(mconley)
Updated•5 years ago
|
Component: Private Browsing → Session Restore
Comment hidden (Intermittent Failures Robot) |
Assignee | ||
Comment 13•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=528bebc2883d
Assignee | ||
Comment 14•5 years ago
|
||
Review commit: https://reviewboard.mozilla.org/r/37103/diff/#index_header See other reviews: https://reviewboard.mozilla.org/r/37103/
Attachment #8724635 -
Flags: review?(dtownsend)
Assignee | ||
Comment 15•5 years ago
|
||
I think I've found the cause - in navigateAndRestore, we're not accounting for the fact that the window might have the closed property set to true on it.
Flags: needinfo?(mconley)
Updated•5 years ago
|
Attachment #8724635 -
Flags: review?(dtownsend) → review+
Comment 16•5 years ago
|
||
Comment on attachment 8724635 [details] MozReview Request: Bug 1228652 - Check for window.closed after flushing messages in navigateAndRestore. r?Mossop https://reviewboard.mozilla.org/r/37103/#review33703
Comment 18•5 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/1e8467611bd6
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox47:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Updated•5 years ago
|
Comment 19•5 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/ba52846ea71b
Whiteboard: [checkin-needed-aurora]
Comment hidden (Intermittent Failures Robot) |
You need to log in
before you can comment on or make changes to this bug.
Description
•