Closed Bug 1228652 Opened 4 years ago Closed 4 years ago

Intermittent e10s browser_privatebrowsing_nonbrowser.js | A promise chain failed to handle a rejection: - at resource:///modules/sessionstore/SessionStore.jsm:3840 - TypeError: this._windows[aWindow.__SSi] is undefined

Categories

(Firefox :: Session Restore, defect)

Product:
Firefox
Component:
Session Restore
Type:
defect
Priority:
Not set

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 47
Tracking Flags:
Tracking Status
e10s + ---
firefox45 --- wontfix
firefox46 --- fixed
firefox47 --- fixed

People

(Reporter: philor, Assigned: mconley)

References

(Blocks 1 open bug)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

MozReview Request: Bug 1228652 - Check for window.closed after flushing messages in navigateAndRestore. r?Mossop
58 bytes, text/x-review-board-request
mossop
: review+
Details
Summary: Intermittent browser_privatebrowsing_nonbrowser.js | A promise chain failed to handle a rejection: - at resource:///modules/sessionstore/SessionStore.jsm:3840 - TypeError: this._windows[aWindow.__SSi] is undefined → Intermittent e10s browser_privatebrowsing_nonbrowser.js | A promise chain failed to handle a rejection: - at resource:///modules/sessionstore/SessionStore.jsm:3840 - TypeError: this._windows[aWindow.__SSi] is undefined
Blocks: e10s-tests
tracking-e10s: --- → +
e10s-only failure that looks related to SessionStore. Any thoughts, Mike? :)
Flags: needinfo?(mconley)
See Also: → 1228648
See Also: → 1229570
See Also: → 1231525
See Also: → 1228476
See Also: → 1233460
See Also: → 1235700
See Also: → 1241018
See Also: → 1244986
Component: Private Browsing → Session Restore
I think I've found the cause - in navigateAndRestore, we're not accounting for the fact that the window might have the closed property set to true on it.
Flags: needinfo?(mconley)
Attachment #8724635 - Flags: review?(dtownsend) → review+
Comment on attachment 8724635 [details]
MozReview Request: Bug 1228652 - Check for window.closed after flushing messages in navigateAndRestore. r?Mossop

https://reviewboard.mozilla.org/r/37103/#review33703
https://hg.mozilla.org/mozilla-central/rev/1e8467611bd6
Status: NEW → RESOLVED
Closed: 4 years ago
status-firefox47: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 47
Assignee: nobody → mconley
status-firefox45: affected → wontfix
Whiteboard: [checkin-needed-aurora]
Duplicate of this bug: 1228648
Duplicate of this bug: 1229570
Duplicate of this bug: 1231525
Duplicate of this bug: 1228476
Duplicate of this bug: 1233460
Duplicate of this bug: 1235700
Duplicate of this bug: 1241018
Duplicate of this bug: 1244986
You need to log in before you can comment on or make changes to this bug.