1229363 - Support sw video codec

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P2)

Description

[Alfredo Yang (:alfredo)]

https://bugzilla.mozilla.org/show_bug.cgi?id=1224887#c19

Comment 1

[Alfredo Yang (:alfredo)]

Attachment: refactory_omx_output

Comment 2

[Alfredo Yang (:alfredo)]

Attachment: enable_video_software_decoding

Comment 3

[Alfredo Yang (:alfredo)]

Attachment: support_sw_video_codec

1. fix input buffer size problem.
2. add SW codec output colour format.
3. refactory audio/video output to MediaDataHelper.

Comment 4

[Alfredo Yang (:alfredo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=c8355e4f5544

Comment 5

[Alfredo Yang (:alfredo)]

Attachment: support_sw_video_codec

Comment 6

[Alfredo Yang (:alfredo)]

Attachment: support_sw_video_codec

Comment 7

[Alfredo Yang (:alfredo)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=36f5c135a7d6

Comment 8

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8705642 [details] [diff] [review]
support_sw_video_codec

Review of attachment 8705642 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/omx/GonkOmxPlatformLayer.cpp
@@ +535,5 @@
> +  // H264 and H263 has different profiles, software codec doesn't support high profile.
> +  // So we use hardware codec only.
> +  if (!IsInEmulator() &&
> +      (mInfo->mMimeType.EqualsLiteral("video/avc") ||
> +       mInfo->mMimeType.EqualsLiteral("video/3gp"))) {

Don't we need to check mime types like in GonkDecoderModule::SupportsMimeType(), do we?
  https://dxr.mozilla.org/mozilla-central/source/dom/media/platforms/gonk/GonkDecoderModule.cpp#64

Comment 9

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8705642 [details] [diff] [review]
support_sw_video_codec

Review of attachment 8705642 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/omx/OmxDataDecoder.cpp
@@ +1020,5 @@
> +      // Get YUV VideoData, it uses more CPU, in most cases, on software codec.
> +      data = CreateYUV420VideoData(aBufferData);
> +    }
> +
> +    // Update vodeo time code, duration... from the raw data.

nit: video

Comment 10

[Sotaro Ikeda [:sotaro]]

Comment on attachment 8705642 [details] [diff] [review]
support_sw_video_codec

Review of attachment 8705642 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/media/platforms/omx/GonkOmxPlatformLayer.cpp
@@ +535,5 @@
> +  // H264 and H263 has different profiles, software codec doesn't support high profile.
> +  // So we use hardware codec only.
> +  if (!IsInEmulator() &&
> +      (mInfo->mMimeType.EqualsLiteral("video/avc") ||
> +       mInfo->mMimeType.EqualsLiteral("video/3gp"))) {

From the comment, it was not clear why video/mp4 video/mp4v-es are not handled here. Can you make it clear?

Comment 11

[Alfredo Yang (:alfredo)]

(In reply to Sotaro Ikeda [:sotaro] from comment #10)
> Comment on attachment 8705642 [details] [diff] [review]
> support_sw_video_codec
> 
> Review of attachment 8705642 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/media/platforms/omx/GonkOmxPlatformLayer.cpp
> @@ +535,5 @@
> > +  // H264 and H263 has different profiles, software codec doesn't support high profile.
> > +  // So we use hardware codec only.
> > +  if (!IsInEmulator() &&
> > +      (mInfo->mMimeType.EqualsLiteral("video/avc") ||
> > +       mInfo->mMimeType.EqualsLiteral("video/3gp"))) {
> 
> From the comment, it was not clear why video/mp4 video/mp4v-es are not
> handled here. Can you make it clear?

I forgot mp4. :)
Added.

Comment 12

[Alfredo Yang (:alfredo)]

Attachment: support_sw_video_codec

Comment 13

[Alfredo Yang (:alfredo)]

Thanks for review!

Comment 14

[Pulsebot]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4be86232c89c

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4be86232c89c