Status

()

defect
P2
normal
RESOLVED FIXED
4 years ago
3 years ago

People

(Reporter: ayang, Assigned: ayang)

Tracking

unspecified
mozilla47
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox47 fixed)

Details

Attachments

(3 attachments)

Assignee

Description

4 years ago
Enable MSE test case on ICS and KK emulator
Assignee

Comment 1

4 years ago
Assignee: nobody → ayang
Depends on: 1239607
Depends on: 1243681
Comment on attachment 8721215 [details]
MozReview Request: Bug 1233410 - Refactor: let component decide which compression format to use. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35609/diff/1-2/
(In reply to John Lin [:jolin][:jhlin] from comment #3)
> Comment on attachment 8721215 [details]
> MozReview Request: Bug 1233410 - Support VP8 video in OpenMAX PDM. r?alfredo
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/35609/diff/1-2/

 Update for offline comments:
 - translate standard VP8 coding type value to proprietary definition.
 - translate VP8 video MIME type.
Assignee

Comment 5

3 years ago
Comment on attachment 8721215 [details]
MozReview Request: Bug 1233410 - Refactor: let component decide which compression format to use. r?alfredo

https://reviewboard.mozilla.org/r/35609/#review32609

LGTM. Thank you.
Attachment #8721215 - Flags: review?(ayang) → review+
Comment on attachment 8721215 [details]
MozReview Request: Bug 1233410 - Refactor: let component decide which compression format to use. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35609/diff/2-3/
Comment on attachment 8721215 [details]
MozReview Request: Bug 1233410 - Refactor: let component decide which compression format to use. r?alfredo

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/35609/diff/3-4/
Attachment #8721215 - Attachment description: MozReview Request: Bug 1233410 - Support VP8 video in OpenMAX PDM. r?alfredo → MozReview Request: Bug 1233410 - Refactor: let component decide which compression format to use. r?alfredo
Address offline comments by letting Gonk platform implementation decide which compression format definition to use:
- refactor: introduce a virtual function for subclasses to override format definition when necessary.
- Let Gonk implementation uses Android proprietary definition for VP8 video.
Assignee

Updated

3 years ago
Attachment #8722354 - Flags: review?(ayang) → review+
Assignee

Comment 11

3 years ago
Comment on attachment 8722354 [details]
MozReview Request: Bug 1233410 - Support VP8 video in OpenMAX PDM. r?alfredo

https://reviewboard.mozilla.org/r/35989/#review32625

Thank you.

Comment 13

3 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/06f762ea5c7f
https://hg.mozilla.org/mozilla-central/rev/f523d4705481
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla47
You need to log in before you can comment on or make changes to this bug.